Skip to content

Conversation

@LucHeart
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings October 21, 2025 22:59
@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2025

⚠️ No Changeset found

Latest commit: 27a886a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors environment configuration to use full URLs instead of domain-only values. The change improves consistency by having environment variables contain complete URLs with protocols (https://) and optional paths, rather than requiring string concatenation throughout the codebase.

Key changes:

  • Environment variables renamed from *_DOMAIN to *_URL format with full URLs including protocols
  • Updated URL construction throughout the codebase to use the URL constructor for proper path joining
  • Added utility functions for WebSocket URL conversion and base path extraction from full URLs

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
vite.config.ts Updated to extract hostname from full URL and validate PUBLIC_SITE_URL
svelte.config.js Added helper functions for WebSocket URL conversion and base path extraction; updated CSP directives to use full URLs
src/routes/(anonymous)/+page.server.ts Updated API configuration to use PUBLIC_BACKEND_API_URL instead of concatenating protocol and domain
src/lib/signalr/index.ts Updated SignalR connection URL construction to use URL constructor with PUBLIC_BACKEND_API_URL
src/lib/api/next/base.ts Simplified URL construction using URL constructor with PUBLIC_BACKEND_API_URL base
src/lib/api/index.ts Updated GetBasePath to validate and return PUBLIC_BACKEND_API_URL directly
.env.test Changed environment variables from domain-only to full URLs with https:// protocol
.env.production Changed environment variables from domain-only to full URLs with https:// protocol
.env.development Changed environment variables from domain-only to full URLs with https:// protocol

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

LucHeart and others added 3 commits October 22, 2025 01:01
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@LucHeart LucHeart requested a review from Copilot October 21, 2025 23:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@LucHeart LucHeart requested a review from Copilot October 21, 2025 23:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@LucHeart LucHeart merged commit e471f2e into develop Oct 22, 2025
4 checks passed
@LucHeart LucHeart deleted the feature/use-full-urls-in-env-config branch October 22, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants