Skip to content

Conversation

@synqotik
Copy link
Contributor

Use dropdowns for some SNMP configuration parameters which have only certain valid values.

Fix SCV icon buttons so they are outside of the FeatherInput controls.

A few other small changes.

External References

@synqotik synqotik force-pushed the jira/NMS-19507-snmp-config-dropdowns branch from 7cb4ce8 to 16c7b6f Compare February 10, 2026 23:05
@synqotik synqotik marked this pull request as ready for review February 10, 2026 23:05
@christianpape
Copy link
Contributor

christianpape commented Feb 11, 2026

Two small things.

First, the „Lookup by IP“: When opening the „Manage SNMP Configuration“ page the „Lookup by IP“ tab is selected. The Location field has „Default“ set. I can enter an IP but if I hit „Lookup“ I get the error message "Must enter IP address and location“. If I click on the Location field and hit lookup again it works. It looks like „Default“ is displayed but not really selected.

Second, if I hat looked up an IP configuration on the „Lookup by IP“ page I see it’s configuration on the "SNMP Configuration Found“ page. If I navigate to another OpenNMS page, e.g. to the Secure Credentials Vault to add something and navigate back to „SNMP Configuration (New)“ the "SNMP Configuration Found“ page is still selected but its contents are not valid. It would be better that when naviagting to „Manage SNMP Configuration“ the „Lookup by IP“ tab is selected.

I was using Safari.

Copy link
Contributor

@christianpape christianpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@synqotik
Copy link
Contributor Author

See comments

Hi @christianpape , good catches! I made updates to fix both of these issues. Lookup by IP location dropdown should now populate correctly. Also, the state is now reset when user goes back to SnmpConfig pages, so it will always display the Lookup by IP search page. Note, we may change the "landing page" to be definitions or something, but if so we can do it in the future once we discuss with UX and support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants