NMS-19486: Support deletion of mibgroups,resourcetypes and systemdefs #8280
+1,257
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rces | Expose services to delete list of mibgroups,resourcetypes and systemdefs
aurang-zeb313
changed the base branch from
develop
to
features/snmp-datacollection-db
Contributor
There was a problem hiding this comment.
Pull request overview
Adds REST v2 delete endpoints and DAO support for bulk deletion of SNMP data collection sources and related entities (MIB groups, resource types, system defs).
Changes:
- Introduces new REST payload models for bulk delete requests.
- Adds REST API interface methods + REST service implementations for delete operations.
- Extends DAOs with bulk-delete methods (HQL
delete ... where id in (...)) for sources and child entities.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/model/SnmpDataCollectionSystemDefDeletePayload.java | Adds request payload for deleting system defs by ID list |
| opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/model/SnmpDataCollectionSourceDeletePayload.java | Adds request payload for deleting collection sources by ID list |
| opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/model/SnmpDataCollectionResourceTypeDeletePayload.java | Adds request payload for deleting resource types by ID list |
| opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/model/SnmpDataCollectionMibGroupDeletePayload.java | Adds request payload for deleting MIB groups by ID list |
| opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/api/DataCollectionConfRestApi.java | Exposes new DELETE endpoints for the above bulk deletions |
| opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/DataCollectionConfRestService.java | Implements REST endpoints and delegates deletions to DAO/service layer |
| opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/DataCollectionConfPersistenceService.java | Adds transactional delete operations with validation against DB state |
| opennms-dao/src/main/java/org/opennms/netmgt/dao/hibernate/SnmpCollectionSystemDefDaoHibernate.java | Adds bulk delete by source + systemDef IDs |
| opennms-dao/src/main/java/org/opennms/netmgt/dao/hibernate/SnmpCollectionSourceDaoHibernate.java | Adds bulk delete by source IDs |
| opennms-dao/src/main/java/org/opennms/netmgt/dao/hibernate/SnmpCollectionResourceTypeDaoHibernate.java | Adds bulk delete by source + resourceType IDs |
| opennms-dao/src/main/java/org/opennms/netmgt/dao/hibernate/SnmpCollectionMibGroupDaoHibernate.java | Adds bulk delete by source + mibGroup IDs |
| opennms-dao-api/src/main/java/org/opennms/netmgt/dao/api/SnmpCollectionSystemDefDao.java | Adds DAO API for bulk systemDef deletion |
| opennms-dao-api/src/main/java/org/opennms/netmgt/dao/api/SnmpCollectionSourceDao.java | Adds DAO API for bulk source deletion |
| opennms-dao-api/src/main/java/org/opennms/netmgt/dao/api/SnmpCollectionResourceTypeDao.java | Adds DAO API for bulk resourceType deletion |
| opennms-dao-api/src/main/java/org/opennms/netmgt/dao/api/SnmpCollectionMibGroupDao.java | Adds DAO API for bulk mibGroup deletion |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/DataCollectionConfRestService.java
Show resolved
Hide resolved
opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/DataCollectionConfRestService.java
Show resolved
Hide resolved
opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/DataCollectionConfRestService.java
Show resolved
Hide resolved
opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/DataCollectionConfRestService.java
Outdated
Show resolved
Hide resolved
opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/DataCollectionConfRestService.java
Show resolved
Hide resolved
opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/api/DataCollectionConfRestApi.java
Show resolved
Hide resolved
...src/main/java/org/opennms/web/rest/v2/model/SnmpDataCollectionResourceTypeDeletePayload.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/opennms/web/rest/v2/model/SnmpDataCollectionResourceTypeDeletePayload.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/opennms/web/rest/v2/model/SnmpDataCollectionResourceTypeDeletePayload.java
Outdated
Show resolved
Hide resolved
opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/DataCollectionConfRestService.java
Show resolved
Hide resolved
cgorantla
changed the title
cgorantla
requested changes
Feb 11, 2026
|
|
||
| @Transactional | ||
| public void deleteSnmpDataCollectionSources(final SnmpDataCollectionSourceDeletePayload request) throws Exception { | ||
| snmpCollectionSourceDao.deleteByIds(request.getSnmpCollectionSourceIds()); |
Contributor
There was a problem hiding this comment.
why not use Service and what happens to it's child entities ?
Member
Author
There was a problem hiding this comment.
if we delete source its child entities will also be deleted
Comment on lines
230
to
240
| final var mibGroupsIds = snmpCollectionMibGroupDao.findAllBySource(snmpDataCollectionSourceId); | ||
|
|
||
| final Set<Integer> databaseMibGroupIds = mibGroupsIds | ||
| .stream() | ||
| .map(SnmpCollectionMibGroup::getId) | ||
| .collect(Collectors.toSet()); | ||
|
|
||
| final var requestMibGroupIds = payload.getMibGroupsIds(); | ||
| final var existingMibGroupIds = requestMibGroupIds.stream() | ||
| .filter(databaseMibGroupIds::contains) | ||
| .toList(); |
Contributor
There was a problem hiding this comment.
Do we need to load all mibgroups to delete ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External References