JICMP-27: Compile with OpenJDK 17 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR updates the project to compile with OpenJDK 17, replacing the deprecated javah tool with javac -h for generating native headers. The changes upgrade build tools, CI configuration, and developer email information to support the modern JDK version.
Changes:
- Updated Maven plugins and dependencies to versions compatible with OpenJDK 17
- Migrated CI/CD configuration from OpenJDK 8 to OpenJDK 17
- Updated email address for developer Ronny Trommer
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pom.xml.in | Updated Maven plugins, changed execution environment to JavaSE-17, and replaced source/target with release configuration |
| m4 | Updated submodule commit reference |
| .circleci/config.yml | Updated CI images and JDK versions from 8 to 17, changed Debian from buster to bookworm, and updated repository URLs to HTTPS |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
indigo423
force-pushed
the
ronny/jicmp-27
branch
3 times, most recently
from
c81f42c to
664905e
Compare
Signed-off-by: Ronny Trommer <[email protected]>
Signed-off-by: Ronny Trommer <[email protected]>
Signed-off-by: Ronny Trommer <[email protected]>
Signed-off-by: Ronny Trommer <[email protected]>
Signed-off-by: Ronny Trommer <[email protected]>
…:17.0-node Signed-off-by: Ronny Trommer <[email protected]>
Signed-off-by: Ronny Trommer <[email protected]>
Signed-off-by: Ronny Trommer <[email protected]>
indigo423
force-pushed
the
ronny/jicmp-27
branch
from
d784672 to
3ad229f
Compare
Signed-off-by: Ronny Trommer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate javah to javac -h to compile with modern JDK. The javah tool to generate native-headers is removed in OpenJDK 10+ and replaced with javac -h. See JEP 313.
JIRA: https://opennms.atlassian.net/browse/JICMP-27