Fix issue of replacing the exiting env#31
Merged
openminddev merged 3 commits intomainfrom Feb 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the logic for retrieving environment variables for containers in
OTA/agent/main.py. The method now combines environment variables from both Docker inspect and the.envfile, providing a more comprehensive and robust approach.Improvements to environment variable retrieval:
_get_container_env_varsmethod now fetches environment variables usingdocker inspectin addition to reading from the.envfile, then combines both sources. This ensures that all relevant environment variables are captured, even if they are set at runtime or differ from the.envfile. [1] [2]