Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to how audio status updates are handled in the live stream audio output, specifically by associating each status update with a unique
request_id(frame ID). This allows for more precise tracking of individual audio requests throughout their lifecycle. The changes ensure that therequest_idis propagated and included in status updates, which can be useful for debugging, analytics, or correlating requests and responses.Enhancements to audio status tracking:
pending_messagedictionary now includes therequest_id(frame ID) when a new audio request is added, enabling downstream tracking._update_audio_statusmethod is updated to accept aframe_idparameter, ensuring that status updates are associated with the correct request._update_audio_statuswithin_process_audionow pass along the relevantrequest_id, so that status transitions (ACTIVE, READY) are tied to the specific request being processed. [1] [2]