Skip to content

Add git.properties file with build id#240

Draft
scottkurz wants to merge 1 commit intoOpenLiberty:mainfrom
scottkurz:add-properties-file-to-jars
Draft

Add git.properties file with build id#240
scottkurz wants to merge 1 commit intoOpenLiberty:mainfrom
scottkurz:add-properties-file-to-jars

Conversation

@scottkurz
Copy link
Copy Markdown
Contributor

@scottkurz scottkurz commented Nov 1, 2023

I copied this from StackOverflow somewhere. Should the git.properties really go right in the root or META-INF? I'm not even sure why I have the build-helper-maven-plugin and not just the other plugin. Leaving as a draft.

Signed-off-by: Scott Kurz <skurz@us.ibm.com>
@cherylking
Copy link
Copy Markdown
Member

Is this going to play well with the maven-shade-plugin we are using to control what goes into the build artifact?

@scottkurz
Copy link
Copy Markdown
Contributor Author

Is this going to play well with the maven-shade-plugin we are using to control what goes into the build artifact?

I think it does, for now...the git.properties file still seems to appear in the final artifact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants