feat(receive): allow servers to customize vender item unpack structure#4166
Merged
alisonrag merged 4 commits intoOpenKore:masterfrom Mar 9, 2026
Merged
Conversation
…Type0 and Sakexe_0
alisonrag
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the
vender_items_listitem unpack process customizable for servers with modified packet structures.Previously, the unpacked fields were mapped using a fixed key order inside
Receive.pm. Some servers change the order or structure of these fields, which required editing core code.This change introduces
vender_items_list_item_keys, allowing server-specific receive modules to define the field order that corresponds tovender_items_list_item_pack.If no custom keys are defined, the original default order is used, ensuring full backward compatibility.
Motivation
Some servers modify packet layouts for vender item lists. Allowing configurable keys avoids hardcoding structures in the core and simplifies support for custom servers.
Changes
vender_items_list_item_keys