Skip to content

fix(github): list checks waiting on others in their own table - #157

Merged
justanotherariel merged 4 commits into
mainfrom
justanotherariel-dashboard-pending-wording
Nov 12, 2026
Merged

justanotherariel merged 4 commits into
mainfrom
justanotherariel-dashboard-pending-wording

Conversation

@justanotherariel

@justanotherariel justanotherariel commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Proposed change

The PR dashboard said "✨ Everything's in order!" whenever nothing failed, even while a pending check (a missing code-owner approval, a blocking label) kept the PR from being merged. With a failure too, those rows sat under "Things to address:", though the author can't act on them.

Pending rows now get their own table, under "👀 Waiting on others before this PR can be merged:", and show 👀 instead of ⏳. "Things to address:" lists only failures and warnings; with warnings but no failures, the same table is headed "Things to look out for:". "Everything's in order!" only shows when nothing fails, warns or waits. The ha-bot status says "1 check waiting" instead of "1 check pending", as GitHub uses "pending" for checks that are still running.

Type of change

  • Dependency upgrade
  • Bugfix
  • New rule or command
  • New repository manifest (enable the bot on another repo)
  • New feature (which adds functionality to an existing engine)
  • Code quality improvement or refactor (incl. tests)

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass (mise run test). Your PR cannot be merged unless tests pass.
  • Lint and type checks pass (mise run check).
  • The code has been formatted (mise run format).
  • Tests have been added to verify that the new code works.
  • There is no commented out or debug code in this PR.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If behaviour, configuration, or environment variables changed:

  • README.md and .env.example have been updated accordingly.

@justanotherariel justanotherariel changed the title fix(github): say the PR waits when dashboard checks are pending fix(github): list checks waiting on others in their own table Nov 12, 2026
@justanotherariel
justanotherariel merged commit f1cc552 into main Nov 12, 2026
9 checks passed
@justanotherariel
justanotherariel deleted the justanotherariel-dashboard-pending-wording branch November 12, 2026 10:50
@ohf-release ohf-release Bot mentioned this pull request Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant