Skip to content

fix(github): treat removing an absent label as done - #145

Merged
justanotherariel merged 1 commit into
mainfrom
justanotherariel-stale-label-removal
Nov 11, 2026
Merged

justanotherariel merged 1 commit into
mainfrom
justanotherariel-stale-label-removal

Conversation

@justanotherariel

Copy link
Copy Markdown
Member

Deployment notes

Proposed change

applyEffects diffs label removals against the labels in the webhook payload. When a dispatch waits behind the item lock, an earlier dispatch may already have removed the label, and GitHub answers 404 "Label does not exist". The bot then logs an "operation failed" warning, about 3 a day, although the item ends up as intended.

A 404 on removeLabel now counts as removed. Any other error still fails the op and gets logged.

Type of change

  • Dependency upgrade
  • Bugfix
  • New rule or command
  • New repository manifest (enable the bot on another repo)
  • New feature (which adds functionality to an existing engine)
  • Code quality improvement or refactor (incl. tests)

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass (mise run test). Your PR cannot be merged unless tests pass.
  • Lint and type checks pass (mise run check).
  • The code has been formatted (mise run format).
  • Tests have been added to verify that the new code works.
  • There is no commented out or debug code in this PR.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If behaviour, configuration, or environment variables changed:

  • README.md and .env.example have been updated accordingly.

@justanotherariel
justanotherariel merged commit 9738aa8 into main Nov 11, 2026
8 checks passed
@justanotherariel
justanotherariel deleted the justanotherariel-stale-label-removal branch November 11, 2026 17:09
@ohf-release ohf-release Bot mentioned this pull request Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant