Skip to content

Conversation

@ZeLonewolf
Copy link

@ZeLonewolf ZeLonewolf commented Jun 21, 2025

Initial incremental step towards OpenHistoricalMap/ohm-website#651

Description

This PR moves most of the raster layers to MapLibre GL and removes associated dead code that I discovered during the process. I'm leaving the standard tile layer for now because it's hooked into a few other places that seemed more complicated to handle.

How has this been tested?

Tested locally, appears to look identically between localhost and openhistoricalmap.org.


.toggleClass("btn-primary", true)
.toggleClass("btn-secondary", false)
.tooltip(true ? "disable" : "enable");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will always resolve to "disable". The ternary is apparently unnecessary because we don’t feature the Tracestrack Topo layer, but will this be a source of conflicts with upstream?

style: {
version: 8,
sources: {
'cyclosm': {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This part of the diff is somewhat inconsistent in its use of single versus double quotation marks.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is like this because the file I pulled it in from was using single quotes. Should I just change them to be consistent through?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, might as well to be internally consistent.

@danrademacher
Copy link
Member

@erictheise is going to look at this as soon as we do an upstream catchup, expected today. Then we'll look at this relative to that newer code from upstream

@1ec5
Copy link
Member

1ec5 commented Oct 8, 2025

#316 eliminated some of the custom maplibre-gl-leaflet integration code in favor of what openstreetmap-website did upstream in openstreetmap#6137. It’s cleaner and more reliable, though there’s some additional code to clean up around how the time slider hooks in. This refactoring conflicts with your PR, but it looks like most of the changes are effectively merged already. The one thing that hasn’t landed is the commented-out option to specify a Tracestrack API key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants