Makefile: create BINDIR before installing - #44
Merged
Conversation
`make install` fails when $(PREFIX)/bin does not exist yet, because `install`
does not create the destination directory:
install fastplong /path/to/prefix/bin/fastplong
install: /path/to/prefix/bin/fastplong: No such file or directory
This happens with any staged install into a fresh prefix (packaging, DESTDIR-style
installs, containers). Create BINDIR first.
7 tasks
Contributor
Author
|
Thanks for merging. Do you have a rough timeline for the next tagged release? Homebrew builds from release tarballs, so the fix only reaches us once it is in a tag. Until then the formula has to carry a No rush on my side if a release is already planned; I just want to know whether to keep the workaround or wait for the tag before the formula is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make installfails when$(PREFIX)/bindoes not exist yet, becauseinstalldoes not create the destination directory:This shows up in any staged install into a fresh prefix (distro/Homebrew packaging, DESTDIR-style installs, containers), where packagers currently have to
mkdir -pthe bin directory themselves before callingmake install.Adding
mkdir -p $(BINDIR)to theinstalltarget fixes it and is a no-op when the directory already exists.The same patch is open for fastp, which has the identical Makefile: OpenGene/fastp#714
Tested:
make install PREFIX=/tmp/fresh-prefixnow succeeds where it previously failed.