Skip to content

remove redundant reflective class access #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
Merged

remove redundant reflective class access #1426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 14 additions & 27 deletions querydsl-libraries/querydsl-r2dbc/src/main/java/com/querydsl/r2dbc/JavaTypeMapping.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@
import com.querydsl.r2dbc.types.DoubleType;
import com.querydsl.r2dbc.types.FloatType;
import com.querydsl.r2dbc.types.IntegerType;
import com.querydsl.r2dbc.types.JSR310InstantType;
import com.querydsl.r2dbc.types.JSR310LocalDateTimeType;
import com.querydsl.r2dbc.types.JSR310LocalDateType;
import com.querydsl.r2dbc.types.JSR310LocalTimeType;
import com.querydsl.r2dbc.types.JSR310OffsetDateTimeType;
import com.querydsl.r2dbc.types.JSR310OffsetTimeType;
import com.querydsl.r2dbc.types.JSR310ZonedDateTimeType;
import com.querydsl.r2dbc.types.LocaleType;
import com.querydsl.r2dbc.types.LongType;
import com.querydsl.r2dbc.types.NullType;
Expand Down Expand Up @@ -82,33 +89,13 @@ class JavaTypeMapping {
registerDefault(new UtilUUIDType());

// initialize java time api (JSR 310) converters only if java 8 is available
try {
Class.forName("java.time.Instant");
registerDefault(
(Type<?, ?>) Class.forName("com.querydsl.r2dbc.types.JSR310InstantType").newInstance());
registerDefault(
(Type<?, ?>)
Class.forName("com.querydsl.r2dbc.types.JSR310LocalDateTimeType").newInstance());
registerDefault(
(Type<?, ?>) Class.forName("com.querydsl.r2dbc.types.JSR310LocalDateType").newInstance());
registerDefault(
(Type<?, ?>) Class.forName("com.querydsl.r2dbc.types.JSR310LocalTimeType").newInstance());
registerDefault(
(Type<?, ?>)
Class.forName("com.querydsl.r2dbc.types.JSR310OffsetDateTimeType").newInstance());
registerDefault(
(Type<?, ?>)
Class.forName("com.querydsl.r2dbc.types.JSR310OffsetTimeType").newInstance());
registerDefault(
(Type<?, ?>)
Class.forName("com.querydsl.r2dbc.types.JSR310ZonedDateTimeType").newInstance());
} catch (ClassNotFoundException e) {
// converters for JSR 310 are not loaded
} catch (InstantiationException e) {
throw new RuntimeException(e);
} catch (IllegalAccessException e) {
throw new RuntimeException(e);
}
registerDefault(new JSR310InstantType());
registerDefault(new JSR310LocalDateTimeType());
registerDefault(new JSR310LocalDateType());
registerDefault(new JSR310LocalTimeType());
registerDefault(new JSR310OffsetDateTimeType());
registerDefault(new JSR310OffsetTimeType());
registerDefault(new JSR310ZonedDateTimeType());
}

private static void registerDefault(Type<?, ?> type) {
Expand Down