Updates to c-bindings #3108
Draft
Updates to c-bindings #3108
+5,559
−958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7a21c0b.
This reverts commit 76d7d57.
This reverts commit 3b9db94.
This reverts commit 6d34d28.
This reverts commit d6f6321.
This reverts commit 1d07a3f.
This reverts commit 895ec6f.
This reverts commit 77efd85.
This reverts commit 0a212c3.
This reverts commit 26143a6.
This reverts commit 4e0ace3.
…ction"" This reverts commit 794e94d.
This reverts commit b9b0d21.
This reverts commit 1005f47.
This reverts commit dd40353.
This reverts commit 93a33fd.
This reverts commit c0a607c.
This reverts commit 609acfa.
This reverts commit 4bc88df.
This reverts commit 70370c8.
This reverts commit 565837e.
This reverts commit c34b688.
This reverts commit 47200a4.
This reverts commit 11d9af7.
This reverts commit 6c9acd2.
This reverts commit 24ead49.
This reverts commit a89ef35.
This reverts commit f936833.
Left notes about what is missing in that
- cleanup moordyn.py to use common stuff in interface_abc - cleanup seastate.py to use common stuff in interface_abc - cleanup aerodyn_inflow.py to use common stuff in interface_abc - use interface_abc with inflowwind.py - use interface_abc with hydrodyn.py
- New external routines: - IfW_C_GetFlowFieldPointer - IfW_C_SetFlowFieldPointer - IfW_C_GetWindVel - Updated to use NWTC_C_BINDING - minor linting - add routine to clear library memory
- ADI_C_GetFlowFieldPointer - ADI_C_SetFlowFieldPointer
to set the pointer, IfW will need to be initialized with a null data set. Init doesn't allow this at the moment
This is accurate for 1st order waves, but will exagerate a bit for 2nd order
- SeaSt_C_GetDens - SeaSt_C_GetDpth - SeaSt_C_GetMSL2SWL Also improved check on valid pointer
Interfaces are not up to date for all the changes here
andrew-platt
added
Module: AeroDyn
Module: InflowWind
Module: SeaState
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready to merge
Feature or improvement description
Several improvements to the c-bindings interfaces were developed jointly with an external partner. This PR brings in updates for the following:
AeroDyn_Inflow_C_bindingSeaState_C_bindingInflowWind_C_bindingpyOpenFASTRelated issue, if one exists
Depends on #3065
Impacted areas of the software
C-binding library interfaces,
pyOpenFAST, and regression testing interfacesAdditional supporting information
Test results, if applicable
ToDo