New wavetank library for HIL simulations with AD+MD #3065
+4,858
−805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7a21c0b.
This reverts commit 76d7d57.
This reverts commit 3b9db94.
This reverts commit 6d34d28.
This reverts commit d6f6321.
This reverts commit 1d07a3f.
This reverts commit 895ec6f.
This reverts commit 77efd85.
This reverts commit 0a212c3.
This reverts commit 26143a6.
This reverts commit 4e0ace3.
…ction"" This reverts commit 794e94d.
This reverts commit b9b0d21.
This reverts commit 1005f47.
This reverts commit dd40353.
This reverts commit 93a33fd.
This reverts commit c0a607c.
This reverts commit 609acfa.
This reverts commit 4bc88df.
This reverts commit 70370c8.
This reverts commit 565837e.
This reverts commit c34b688.
This reverts commit 47200a4.
This reverts commit 11d9af7.
This reverts commit 6c9acd2.
This reverts commit 24ead49.
This reverts commit a89ef35.
This reverts commit f936833.
andrew-platt
force-pushed
the
wavetank3
branch
from
da55bfc to
7664528
Compare
- routines that WaveTimeShift had been added to no longer exist, so restructure the approach
andrew-platt
force-pushed
the
wavetank3
branch
6 times, most recently
from
30367e6 to
e159244
Compare
Without this approach, errors occur when making the _C_Binding.f90 for static and shared in parallel.
andrew-platt
force-pushed
the
wavetank3
branch
from
e159244 to
d0fb325
Compare
andrew-platt
force-pushed
the
wavetank3
branch
from
2cb508b to
224e772
Compare
Error handling in CalcLoadsAtWRP was not initialized
andrew-platt
force-pushed
the
wavetank3
branch
from
a393933 to
9ca10b3
Compare
This was referenced Dec 22, 2025
deslaughter
reviewed
Dec 23, 2025
Comment on lines
183
to
208
| #-------------------------------------- | ||
| # Error levels | ||
| #-------------------------------------- | ||
| error_levels: Dict[int, str] = { | ||
| 0: "None", | ||
| 1: "Info", | ||
| 2: "Warning", | ||
| 3: "Severe Error", | ||
| 4: "Fatal Error" | ||
| } | ||
|
|
||
| # Debug output file: When coupled into another code, an array of position/orientation, | ||
| # velocities, and accelerations are passed in, and an array of Forces + Moments is | ||
| # returned. For debugging, it may be useful to dump all off this to a file. | ||
| debug_output_file: str = "DbgOutputs.out" | ||
| debug_outputs: int = 1 # For checking the interface, set this to 1 | ||
|
|
||
| #-------------------------------------- | ||
| # Constants | ||
| #-------------------------------------- | ||
| # NOTE: The length of the error message in Fortran is determined by the | ||
| # ErrMsgLen variable in the NWTC_Base.f90 file. If ErrMsgLen is modified, | ||
| # the corresponding size here must also be updated to match. | ||
| ERROR_MESSAGE_LENGTH: int = 8197 | ||
| DEFAULT_STRING_LENGTH: int = 1025 | ||
|
|
Collaborator
There was a problem hiding this comment.
Are these included in the OpenFASTInterfaceType?
Collaborator
Author
There was a problem hiding this comment.
Good catch.
There is an inconsistency in the names used that I had not sorted out (ERROR_MSG_C_LEN in OpenFASTInterfaceType vs. ERROR_MESSAGE_LENGTH). Several of the other python libraries have this inconsistency.
I'll make an attempt to revise this, but it might take a bit of time. Alternatively, we can add it as an action item on the 5.0.0 release.
Initial commit, it doesn't work yet. Restructuring required.
There is a huge initial transient that needs addressing at some point
andrew-platt
force-pushed
the
wavetank3
branch
from
43c0c4b to
3a79346
Compare
copy of files from MHK_RM1_Floating_Tank-scaled case -- GH actions doesn't have this case copied in the integrations test
andrew-platt
force-pushed
the
wavetank3
branch
from
2d0357e to
44171ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT not ready for merging
Feature or improvement description
Related issue, if one exists
None
Impacted areas of the software
Updates to following modules and interfaces:
AeroDyn_Inflow_C_BindinglibraryMoorDyn_C_BindinglibrarySeaState_C_BindinglibrarypyOpenFASTchangesNWTC_LibraryCUto a different value for writing to file instead of output to screen (used with LabView)some other details to fill out here
Additional supporting information
Test results, if applicable
New test case
Complete before ready for review