[feature/patina-boot] patina_boot: Refactor to trait-based boot orchestration design#1333
Draft
kat-perez wants to merge 4 commits intoOpenDevicePartnership:feature/patina-bootfrom
Draft
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Introduces BootOrchestrator trait, BootDispatcher component, and SimpleBootManager implementation. Updates config types and helper functions with SimpleBootConfig for fixed primary/secondary topologies.
73a3dd8 to
a1525e3
Compare
Remove explicit `(crate::BootOrchestrator)` link target that rustdoc flags as redundant since the label resolves to the same destination.
…d SimpleBootConfig::default Increase patch coverage above 80% by testing previously uncovered constructor paths: from_options, from_config (with/without hotkey, with failure handler), and the Default impl for SimpleBootConfig.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor
patina_bootfrom a component-based design to a trait-based design per the updated boot orchestration RFC.Old design:
BootOrchestratorandConsoleDiscoverywere standalone Patina#[component]s that each independently implemented boot logic.New design:
BootOrchestrator: Plain Rust trait defining the boot flow interfaceBootDispatcher: Single Patina#[component]that installs the BDS architectural protocol and delegates toBox<dyn BootOrchestrator>SimpleBootManager: Default trait implementation underimpls/, constructed viafrom_options(BootOptions)orfrom_config(SimpleBootConfig)Also adds
SimpleBootConfigfor platforms with fixed primary/secondary boot topologies, and updates doc references throughout.How This Was Tested
cargo build -p patina_bootcargo test -p patina_boot— 39 tests pass (config + helpers)cargo clippy -p patina_boot— zero warningsIntegration Instructions
Replace component registration: