Skip to content

patina_adv_logger: Add logger info v6 support#1296

Merged
makubacki merged 1 commit intoOpenDevicePartnership:mainfrom
makubacki:add_adv_logger_info_v6_support
Feb 10, 2026
Merged

patina_adv_logger: Add logger info v6 support#1296
makubacki merged 1 commit intoOpenDevicePartnership:mainfrom
makubacki:add_adv_logger_info_v6_support

Conversation

@makubacki
Copy link
Collaborator

Description

Support using the v6 logger info structure for the advanced logger.

Previously, only v5 was supported, in this change only v6 is supported. A future change may add support for both.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

  • Verify advanced logger HOB is loaded during initialization
  • Dump memory log at EFI shell to verify log contents

Integration Instructions

@makubacki makubacki self-assigned this Feb 7, 2026
@makubacki
Copy link
Collaborator Author

I think it'd be best to support both v5 and v6 to not have adv logger restrict how patina versions can be matched to platforms. I'm leaving this in draft until I add the backward compatibility support for v5.

@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

❌ Patch coverage is 85.22167% with 30 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
components/patina_adv_logger/src/logger.rs 62.50% 15 Missing ⚠️
components/patina_adv_logger/src/memory_log.rs 90.80% 15 Missing ⚠️

📢 Thoughts on this report? Let us know!

@makubacki makubacki force-pushed the add_adv_logger_info_v6_support branch from e27b5c0 to b0624e7 Compare February 9, 2026 15:27
@makubacki makubacki marked this pull request as ready for review February 9, 2026 22:50
@makubacki
Copy link
Collaborator Author

I think it'd be best to support both v5 and v6 to not have adv logger restrict how patina versions can be matched to platforms. I'm leaving this in draft until I add the backward compatibility support for v5.

Pushed the update to support both v5 and v6 adv logger info structures. I've verified both on QEMU. I am finishing testing on an Intel physical platform (against both v5 and v6). I'll report back when that is done but we can start reviews now.

@makubacki makubacki force-pushed the add_adv_logger_info_v6_support branch from b0624e7 to aabd37a Compare February 10, 2026 03:09
Support using the v6 logger info structure for the advanced logger.

Previously, only v5 was supported, in this change only v6 is
supported. A future change may add support for both.

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
@makubacki makubacki force-pushed the add_adv_logger_info_v6_support branch from aabd37a to 89a81dd Compare February 10, 2026 03:23
@makubacki makubacki enabled auto-merge (squash) February 10, 2026 03:27
@makubacki makubacki merged commit d4d90ea into OpenDevicePartnership:main Feb 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants