Skip to content

MessageHandler to replace service_list! macro#44

Open
dymk wants to merge 2 commits intoOpenDevicePartnership:mainfrom
dymk:log-service-event-loop-matching
Open

MessageHandler to replace service_list! macro#44
dymk wants to merge 2 commits intoOpenDevicePartnership:mainfrom
dymk:log-service-event-loop-matching

Conversation

@dymk
Copy link
Collaborator

@dymk dymk commented Feb 27, 2026

  • Replace service_list! macro with MessageHandler, which provides an API that makes it more obvious what is happening instead of hiding the "build a static linked list" magic behind a macro.
  • Make UUID and NAME constants on the Service trait, as they shouldn't be dynamically computed values
  • Rename RegisterPayload to DirectMessagePayload to make it more clear that it's not just the raw register values x0... from the incoming FFA message (it's x4... onwards).
  • Remove indirection with the Payload trait which wasn't adding any value other than making the direct message types themselves be directly usable as their message payload... which didn't actually make the code using that functionality any cleaner.

@dymk dymk requested a review from philgweber as a code owner February 27, 2026 20:52
Copy link
Collaborator

@philgweber philgweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dymk dymk requested a review from williampMSFT February 27, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants