Remove blanket impl for &mut T and add wrapper macro#34
Merged
tullom merged 1 commit intoOpenDevicePartnership:mainfrom Jan 5, 2026
Merged
Conversation
tullom
requested review from
gjpmsft,
jerrysxie,
madeleyneVaca and
williampMSFT
- Types that wrap an object that implements SmartBattery are common, and having to impl SmartBattery for the wrapper results in lots of boilerplate. This change adds a macro to reduce boilerplate.
tullom
force-pushed
the
remove-impl-for-mutT-and-add-wrapper-macro
branch
from
ca429ca to
72d5fec
Compare
Contributor
|
Long-term we should refactor the code so that we don't have to explicitly implement traits for |
RobertZ2011
approved these changes
Jan 5, 2026
kurtjd
approved these changes
Jan 5, 2026
Contributor
Author
The trait methods all take in a mutable reference to T so technically downstream users will never have to implement the trait for &mut T assuming the trait is implemented for T. (I could be wrong but that's my understanding of these blanked impls for &mut T, it was never needed to begin with). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #26