fix(settings): improve keybind binding UX (OPEN-54)#265
Draft
fix(settings): improve keybind binding UX (OPEN-54)#265
Conversation
- Add press-to-bind and paste support for shortcut fields (read-only inputs) - Detect duplicate shortcuts and reserve sidebar toggle (Meta+G / Ctrl+Shift+G) - Expose recording shortcut in settings; include anti-AFK in stream conflict checks - Export shortcutFromKeyboardEvent helper; align sidebar hint with canonical Meta+G Co-authored-by: Zortos <zortosdev@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses OPEN-54 by making shortcut configuration in Settings and the stream sidebar easier and safer.
Changes
onPastehandlers (needed because read-only inputs often block default paste).Meta+Gon macOS,Ctrl+Shift+Gelsewhere), matching the actual handler inStreamView.shortcutToggleRecordingwas already persisted but had no Settings UI; it is now editable alongside the others and included in reset-to-defaults.formatShortcutForDisplaywith canonicalMeta+Gon Mac.<label>wrappers around inputs with separate labels so clicking the label text no longer steals focus from the adjacent field. Read-only bind fields use a pointer cursor in CSS.Testing
npm installandnpx tsc --noEmitfor bothtsconfig.node.jsonandtsconfig.json(pass).Linear Issue: OPEN-54