-
-
Notifications
You must be signed in to change notification settings - Fork 102
Android App #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zortos293
wants to merge
37
commits into
dev
Choose a base branch
from
capy/android-capacitor-target
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Android App #251
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
3f18813
Add Capacitor Android target and platform abstraction
zortos293 ec1dd5f
Fix Android review issues
zortos293 7b88b70
Unify Android package naming
zortos293 698591d
Add Android APK CI build
zortos293 787f173
Remove Capacitor HTTP plugin dependency
zortos293 3eb35a2
Match Android auth callback to desktop
zortos293 5b26e58
Fix Android localhost auth plugin compile
zortos293 07b3379
Fix Android localhost OAuth callback flow
zortos293 c24021b
Match Android OAuth redirect to desktop localhost flow
zortos293 528cbdc
Revert "Match Android OAuth redirect to desktop localhost flow"
zortos293 889d9d7
Harden Android localhost auth callback handling
zortos293 01c6b94
Merge dev into Android Capacitor target
zortos293 dc2ae3e
Use WebView-based Android OAuth interception
zortos293 f3703d6
Fix Android auth state after WebView login
zortos293 2e7bf3d
Align Android session creation with desktop payload
zortos293 14cb1fd
Merge branch 'dev' into capy/android-capacitor-target
Kief5555 4f1fdd1
Resolve Package lock issues
Kief5555 b839606
Fix linter errors
Kief5555 d7ff05a
Merge origin/dev into capy/android-capacitor-target
zortos293 75b94ad
Apply Android PR review fixes
zortos293 e6946d3
Fix Android session parity follow-ups
zortos293 915c4ff
Fix Android follow-up parity issues
zortos293 0b83461
Fix Android runtime follow-up regressions
zortos293 28034b9
Fix Android splash and media write follow-ups
zortos293 ad9e892
Fix Android polling and packaging follow-ups
zortos293 ca53b28
Fix Android session conflict and relay follow-ups
zortos293 f84b464
Fix Android wrapper and relay candidate replay
zortos293 777d462
Fix avatar fallback escaping and gating
zortos293 8017b40
Fix Android fullscreen back and ICE fallback
zortos293 438b2f6
Fix Android signaling endpoint selection
zortos293 a18064b
Preserve Android active session signaling hosts
zortos293 c22e682
Scope relay ICE replay to current offer
zortos293 2f68193
Align Android ad and signaling handling
zortos293 369fee4
Fix Android parity follow-up issues
zortos293 02abc96
Refine Android ICE scope handling
zortos293 0095b6c
Fix Android signaling and fullscreen follow-ups
zortos293 1c16b18
Fix Android active session and relay issues
zortos293 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| # Using Android gitignore template: https://github.com/github/gitignore/blob/HEAD/Android.gitignore | ||
|
|
||
| # Built application files | ||
| *.apk | ||
| *.aar | ||
| *.ap_ | ||
| *.aab | ||
|
|
||
| # Files for the ART/Dalvik VM | ||
| *.dex | ||
|
|
||
| # Java class files | ||
| *.class | ||
|
|
||
| # Generated files | ||
| bin/ | ||
| gen/ | ||
| out/ | ||
| # Uncomment the following line in case you need and you don't have the release build type files in your app | ||
| # release/ | ||
|
|
||
| # Gradle files | ||
| .gradle/ | ||
| build/ | ||
|
|
||
| # Local configuration file (sdk path, etc) | ||
| local.properties | ||
|
|
||
| # Proguard folder generated by Eclipse | ||
| proguard/ | ||
|
|
||
| # Log Files | ||
| *.log | ||
|
|
||
| # Android Studio Navigation editor temp files | ||
| .navigation/ | ||
|
|
||
| # Android Studio captures folder | ||
| captures/ | ||
|
|
||
| # IntelliJ | ||
| *.iml | ||
| .idea/workspace.xml | ||
| .idea/tasks.xml | ||
| .idea/gradle.xml | ||
| .idea/assetWizardSettings.xml | ||
| .idea/dictionaries | ||
| .idea/libraries | ||
| # Android Studio 3 in .gitignore file. | ||
| .idea/caches | ||
| .idea/modules.xml | ||
| # Comment next line if keeping position of elements in Navigation Editor is relevant for you | ||
| .idea/navEditor.xml | ||
|
|
||
| # Keystore files | ||
| # Uncomment the following lines if you do not want to check your keystore files in. | ||
| #*.jks | ||
| #*.keystore | ||
|
|
||
| # External native build folder generated in Android Studio 2.2 and later | ||
| .externalNativeBuild | ||
| .cxx/ | ||
|
|
||
| # Google Services (e.g. APIs or Firebase) | ||
| # google-services.json | ||
|
|
||
| # Freeline | ||
| freeline.py | ||
| freeline/ | ||
| freeline_project_description.json | ||
|
|
||
| # fastlane | ||
| fastlane/report.xml | ||
| fastlane/Preview.html | ||
| fastlane/screenshots | ||
| fastlane/test_output | ||
| fastlane/readme.md | ||
|
|
||
| # Version control | ||
| vcs.xml | ||
|
|
||
| # lint | ||
| lint/intermediates/ | ||
| lint/generated/ | ||
| lint/outputs/ | ||
| lint/tmp/ | ||
| # lint/reports/ | ||
|
|
||
| # Android Profiling | ||
| *.hprof | ||
|
|
||
| # Cordova plugins for Capacitor | ||
| capacitor-cordova-android-plugins | ||
|
|
||
| # Copied web assets | ||
| app/src/main/assets/public | ||
|
|
||
| # Generated Config files | ||
| app/src/main/assets/capacitor.config.json | ||
| app/src/main/assets/capacitor.plugins.json | ||
| app/src/main/res/xml/config.xml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| /build/* | ||
| !/build/.npmkeep |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[🟡 Medium] [🟡 Investigate]
android-actions/setup-androidonly installs the command-line tools andplatform-toolsby default, but this PR pins the Android project to API 36 in @opennow-stable/android/variables.gradle. That means the new job is only green as long as the hosted Ubuntu image happens to prebundle the required SDK platform/build-tools; on a fresh or rotated runner,./gradlew assembleDebugwill fail before compilation with a missingandroid-36/build-tools error. Explicitly installing the platform (and matching build-tools) in the workflow makes the Android build reproducible.