Use std::threads #60
Merged
Use std::threads #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyle-singer
commented
Dec 15, 2025
| unsigned int worker_start = 1; | ||
| for (unsigned int i = worker_start; i < g->nworkers; i++) { | ||
| int status = pthread_join(g->threads[i], nullptr); | ||
| if (status != 0) |
Collaborator
Author
There was a problem hiding this comment.
I would have liked to have kept these cilkrts_bug calls on failed join/create, but exceptions are turned off in the runtime so any exception should result in std::terminate
| cilkrts_bug(nullptr, "Cilk: thread creation (%u) failed: %s", | ||
| worker_start, strerror(status)); | ||
| } | ||
| new (&g->threads[worker_start]) std::thread{ |
Contributor
There was a problem hiding this comment.
Isn't the std::thread already constructed by the new [] call?
Collaborator
Author
There was a problem hiding this comment.
new [] would invoke the default constructor, which creates an object that doesn't actually represent a running thread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace pthread_t, pthread_create, and pthread_join with the C++ thread implementations.