Fix DEC and longitude conversions in Meade commands - #296
Open
GJayLG wants to merge 2 commits into
Open
Conversation
After the Meade parser refactor, DEC targets and syncs were treated as degrees from the pole instead of celestial declination, and the longitude sign convention (east negative on the wire) was dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #291 the Meade DEC handlers stopped converting between celestial
declination and the internal "degrees from pole" representation. A goto
to +26 36'08" was treated as 26.6 from the pole instead of 63.4, so
the mount pointed at the wrong part of the sky, and every platesolve
sync made the error worse.
The same refactor dropped the sign handling for longitude on the Meade wire east is negative, but the mount stores cartographic longitude
(east positive). That gave a wrong LST for observers east of Greenwich