Improvement: Create new message handler for inbound/outbound messages to support RabbitMQ/others #88 #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhurusurfa
reviewed
Nov 16, 2019
Comment on lines
+30
to
+31
| public abstract class MessageBuilderModule extends BaseReceiverModule { | ||
|
|
Contributor
There was a problem hiding this comment.
Why are you re-implementing the MessageBuilderModule?
If there is something that you need in the existing one then lets talk about enhancing it rather than duplicating all the code.
Member
Author
|
The original uses the filename to get the partnership info and other
metadata.
MQ messages have the headers for that purpose. That's was basically the
difference.
J
…On Sat, Nov 16, 2019, 10:14 AM Christopher Broderick < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
Plugins-MQ/src/main/java/com/greicodex/openas2/plugins/mq/MessageBuilderModule.java
<#175 (comment)>:
> +public abstract class MessageBuilderModule extends BaseReceiverModule {
+
Why are you re-implementing the MessageBuilderModule?
If there is something that you need in the existing one then lets talk
about enhancing it rather than duplicating all the code.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#175?email_source=notifications&email_token=AA2QND7R75EMOPMH5CNFZ2TQT755FA5CNFSM4JN7TLL2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLZ6AEY#pullrequestreview-317972499>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2QND2GTWA73IYPWML634DQT755FANCNFSM4JN7TLLQ>
.
|
Contributor
|
Ok - lets make the retrieval of that info into a method in MessageBuilderModule then it can be overridden by modules that need something diffferenmt if necessary or simply pass additional parameters in the AS2Message context object to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin allows OpenAS2 to interconnect with a Message Queue Broker (i.e RabbitMQ) for message exchange and message tracking events.