-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[php-nextgen] Cast $weight to int in HeaderSelector::getNextWeight() #22423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[php-nextgen] Cast $weight to int in HeaderSelector::getNextWeight() #22423
Conversation
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
e844fa7 to
9a92cd5
Compare
|
Hi @wing328, Thanks for the quick reply, I fixed the commit and pushed again. |
| /** | ||
| * @param array[] $headers | ||
| * @param float $currentWeight | ||
| * @param int $currentWeight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR
is it correct to say that $currentWeight can be any value between 0 and 1 ?
ref: https://developer.mozilla.org/en-US/docs/Glossary/Quality_values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aah I see, my bad, thought this value was between 1 and 1000. I changed the type to float in all methods
9a92cd5 to
dcc82ca
Compare
dcc82ca to
0338bde
Compare
|
I think the root cause of this issue is I think changing the parameter type of a single private method is better than changing parameter and return types of any public methods. |
This change prevents type casting issues between float and int when multiple
jsonaccept headers can be used:Argument #2 ($weight) must be of type int, float given.cc @jebentier @dkarlovi, @mandrean, @jfastnacht, @ybelenko, @renepardon
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)