Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,10 @@ public void setRightExample(Object rightExample) {

@Override
public DiffResult isChanged() {
if (!Objects.equals(leftExample, rightExample)) {
if (!Objects.deepEquals(leftExample, rightExample)) {
return DiffResult.METADATA;
}

return DiffResult.NO_CHANGES;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public void setRightExamples(Object rightExamples) {

@Override
public DiffResult isChanged() {
if (!Objects.equals(leftExamples, rightExamples)) {
if (!Objects.deepEquals(leftExamples, rightExamples)) {
return DiffResult.METADATA;
}
return DiffResult.NO_CHANGES;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public void render(ChangedOpenApi diff, OutputStreamWriter outputStreamWriter) {
diff.getNewSpecOpenApi().getInfo().getVersion()));
safelyAppend(outputStreamWriter, System.lineSeparator());
safelyAppend(outputStreamWriter, System.lineSeparator());
safelyAppend(outputStreamWriter, "NOTE: No differences. Specifications are equivalents");
safelyAppend(outputStreamWriter, "NOTE: No differences. Specifications are equivalent");
} else {
safelyAppend(
outputStreamWriter,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public class ConsoleRender implements Render {
public void render(ChangedOpenApi diff, OutputStreamWriter outputStreamWriter) {
this.diff = diff;
if (diff.isUnchanged()) {
safelyAppend(outputStreamWriter, "No differences. Specifications are equivalents");
safelyAppend(outputStreamWriter, "No differences. Specifications are equivalent");
} else {
safelyAppend(outputStreamWriter, bigTitle("Api Change Log"));
safelyAppend(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -438,4 +438,21 @@ public void testAllOfDiff() {
assertThat(changedSchema.getRequired().getMissing()).containsExactly("fieldA");
assertThat(changedSchema.getRequired().getIncreased()).isEmpty();
}

@Test
void renderShowsNoDifferencesWhenCSVMediaTypeResponseExampleIsByteArray() {
ChangedOpenApi changedOpenApi =
OpenApiCompare.fromLocations(
"schemaDiff/issue-828-binary-example-for-csv-media-type.yaml",
"schemaDiff/issue-828-binary-example-for-csv-media-type.yaml");

assertThat(changedOpenApi).isNotNull();

assertThat(changedOpenApi.isUnchanged()).isTrue();
assertThat(changedOpenApi.isDifferent()).isFalse();
assertThat(changedOpenApi.isChanged()).isEqualTo(DiffResult.NO_CHANGES);
assertThat(changedOpenApi.isIncompatible()).isFalse();
assertThat(changedOpenApi.isCompatible()).isTrue();
assertThat(changedOpenApi.isCoreChanged()).isEqualTo(DiffResult.NO_CHANGES);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
openapi: 3.0.1
info:
title: My API
version: 1.0.0
paths:
/api/v1/csv:
get:
operationId: someCsvEndpoint
responses:
"200":
content:
text/csv:
schema:
type: string
format: binary
example: Example
description: Successful operation
security:
- Bearer: []
summary: Download a CSV or something
components:
securitySchemes:
Bearer:
bearerFormat: JWT
scheme: bearer
type: http