issue 1111 set list_job_results list items with stac1.1 #430
Conversation
| ) | ||
|
|
||
|
|
||
| if len(result_metadata.items) > 0 : |
There was a problem hiding this comment.
| if len(result_metadata.items) > 0 : | |
| if result_metadata.items: |
I would take the opportunity to replace this as it it shorter, safer and expresses the intent better.
|
|
||
| resp = api110.get(f"/jobs/{job_id}/results", headers=self.AUTH_HEADER).assert_status_code(200) | ||
|
|
||
| assert "assets" in resp.json |
There was a problem hiding this comment.
Test the actual value of this assets property.
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if len(result_metadata.items) > 0 : | ||
| assets = { | ||
| item_key + "_" + asset_key: asset_metadata | ||
| for item_key, item_metadata in result_items.items() | ||
| for asset_key, asset_metadata in item_metadata.get("assets").items() | ||
| } |
There was a problem hiding this comment.
When items are present the collection’s assets are now rebuilt straight from result_metadata.items (item_metadata.get("assets").items()) without calling _asset_object. In the STAC 1.0 path each asset is wrapped by _asset_object, which injects signed/absolute hrefs and honours the asset flag. The new branch therefore returns raw backend metadata for STAC 1.1, which can omit href entirely or contain unsigned/internal paths, breaking download links for backends that rely on asset_url.build_url or URL signing. This regression only manifests for jobs producing STAC 1.1 items and makes the collection response unusable for clients expecting valid asset URLs.
Useful? React with 👍 / 👎.
follow up on #411