fix: stop embed page rendering its own html/head/body (closes #827) - #897
Closed
Obiajulu-gif wants to merge 1 commit into
Closed
fix: stop embed page rendering its own html/head/body (closes #827)#897Obiajulu-gif wants to merge 1 commit into
Obiajulu-gif wants to merge 1 commit into
Conversation
…t#827) frontend/src/app/embed/[username]/page.tsx rendered its own <html>/ <head>/<body> with no layout.tsx to opt out of the root layout, so Next.js nested it inside app/layout.tsx's own <html>/<body>. Browsers hoist the inner <head> content out of the tree, /embed.css was never actually applied, and the "background: transparent" body style had no effect — breaking the embed widget's appearance in iframes. Added frontend/src/app/embed/layout.tsx as a bare passthrough and removed the page's own document tags. Since the route still inherits the root layout's <body> (there's no way to fully opt out in the App Router), embed.css now forces background: transparent !important on html/body so the widget still renders transparently. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@Obiajulu-gif Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
Closing — the original combined PR #842 (which this was split from) was already merged upstream, so this duplicates already-merged work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #842 per request. Closes #827.