Skip to content

Fix issues #886, #887, #888, #889: Multiple fixes across backend, fro… - #891

Merged
OlaGreat merged 1 commit into
OlaGreat:mainfrom
STX-Boot:fix/886-887-888-889-multiple-issues
Jul 25, 2026
Merged

Fix issues #886, #887, #888, #889: Multiple fixes across backend, fro…#891
OlaGreat merged 1 commit into
OlaGreat:mainfrom
STX-Boot:fix/886-887-888-889-multiple-issues

Conversation

@STX-Boot

Copy link
Copy Markdown
Contributor

…ntend, and contract

Closes #886 - Fix milestone progress division by zero when targetAmount is 0

  • Added zero guard before dividing in profile page milestone progress calculation
  • MilestoneCard component already had the guard in place

Closes #887 - Correct false statements in SECURITY.md about contract capabilities

  • Fixed claim about "no admin key" - contract does have admin key for pause/unpause
  • Updated trust model section to accurately reflect pause function existence
  • Clarified fund custody and token transfer behavior
  • Added note about keeping SECURITY.md in sync with contract changes

Closes #888 - Swagger API documentation hardcodes localhost:4000

  • Made /docs.json endpoint dynamic, derives URL from BACKEND_URL env var
  • Falls back to request-derived URL if BACKEND_URL not set
  • Also updated swagger spec definition to support BACKEND_URL

Closes #889 - Document DRIP_SCHEDULER_ENABLED environment variable

  • Added DRIP_SCHEDULER_ENABLED to backend/.env.example with explanatory comment

What does this PR do?

Related issue

Closes #

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Docs / config only

How to test

Checklist

  • I have read the CONTRIBUTING guide
  • My branch is up to date with main
  • Linter passes (npm run lint)
  • Tests pass (npm test) if applicable
  • I have not committed .env files or secrets

…ltiple fixes across backend, frontend, and contract

OlaGreat#886 - Fix milestone progress division by zero when targetAmount is 0
- Added zero guard before dividing in profile page milestone progress calculation
- MilestoneCard component already had the guard in place

OlaGreat#887 - Correct false statements in SECURITY.md about contract capabilities
- Fixed claim about "no admin key" - contract does have admin key for pause/unpause
- Updated trust model section to accurately reflect pause function existence
- Clarified fund custody and token transfer behavior
- Added note about keeping SECURITY.md in sync with contract changes

OlaGreat#888 - Swagger API documentation hardcodes localhost:4000
- Made /docs.json endpoint dynamic, derives URL from BACKEND_URL env var
- Falls back to request-derived URL if BACKEND_URL not set
- Also updated swagger spec definition to support BACKEND_URL

OlaGreat#889 - Document DRIP_SCHEDULER_ENABLED environment variable
- Added DRIP_SCHEDULER_ENABLED to backend/.env.example with explanatory comment
@drips-wave

drips-wave Bot commented Jul 25, 2026

Copy link
Copy Markdown

@STX-Boot Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@OlaGreat
OlaGreat merged commit 6e3956c into OlaGreat:main Jul 25, 2026
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment