Fix/796 797 798 799 backend bugs - #850
Merged
OlaGreat merged 3 commits intoJul 25, 2026
Merged
Conversation
- Reject non-numeric/zero/negative targetAmount values on milestone create and update instead of letting Prisma throw an unhandled 500 - Base recurring support nextRunAt on the original scheduled time instead of the processing time, so late runs no longer drift the schedule forward Closes OlaGreat#797 Closes OlaGreat#796
- Add a dedicated feedLimiter (10 req/min per IP) to GET /profiles/:username/feed.xml - Reject PATCH requests that change targetAmount on an already-reached milestone, and auto-mark a milestone as reached if the new targetAmount drops to or below currentAmount Closes OlaGreat#799 Closes OlaGreat#798
|
@olywales-stack Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
targetAmountas a positive decimal (up to 7 places) on both create and update, instead of letting Prisma throw an unhandled 500 on non-numeric inputnextRunAtcalculation to base off the originalsupport.nextRunAtinstead of the late-processing time, preventing schedule driftGET /profiles/:username/feed.xml)targetAmountchanges on already-reached milestones, and auto-mark a milestone asreachedif a loweredtargetAmountdrops to/belowcurrentAmountTest plan
targetAmountchange → expect 400targetAmountbelowcurrentAmount→ status flips toreachedtargetAmount: 'abc','0','-50'→ expect 400, not 500feed.xml>10 times/min from one IP → expect 429Closes #796
Closes #797
Closes #798
Closes #799