-
Notifications
You must be signed in to change notification settings - Fork 0
Optimizes Docker image builds and automates tracking of upstream a16z/helios releases. #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
OisinKyne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it works to me. We could plausibly delete basically everything in this repo bar these two files if i understand how they work correctly.
| # Set a default entrypoint | ||
| ENTRYPOINT ["helios"] | ||
| ENTRYPOINT ["helios"] | ||
| CMD ["--help"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't this CMD prevent the image from starting normally unless you know to override it with an empty cmd?
| REPO="a16z/helios" && \ | ||
| if [ -z "$HELIOS_VERSION" ] || [ "$HELIOS_VERSION" = "latest" ]; then \ | ||
| TAG=$(curl -s https://api.github.com/repos/$REPO/releases/latest | grep -o '"tag_name": "[^"]*' | grep -o '[^"]*$'); \ | ||
| else \ | ||
| TAG="$HELIOS_VERSION"; \ | ||
| fi && \ | ||
| PLATFORM="linux" && \ | ||
| case "$TARGETARCH" in \ | ||
| amd64) ARCHITECTURE="amd64" ;; \ | ||
| arm64) ARCHITECTURE="arm64" ;; \ | ||
| arm) ARCHITECTURE="armv7" ;; \ | ||
| *) ARCHITECTURE="amd64" ;; \ | ||
| esac && \ | ||
| TARBALL_URL="https://github.com/$REPO/releases/download/${TAG}/helios_${PLATFORM}_${ARCHITECTURE}.tar.gz" && \ | ||
| echo "Downloading helios ${TAG} for ${PLATFORM}_${ARCHITECTURE}" && \ | ||
| mkdir -p /helios && \ | ||
| curl -L "$TARBALL_URL" | tar -xzC /helios |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do this, do we need to keep the rest of the repo at all? like this repo could basically just be this dockerfile and some github actions?
Summary
Optimizes Docker image builds and automates tracking of upstream a16z/helios releases.
Changes
obolnetwork/helios) and GHCR (ghcr.io/obolnetwork/helios)How it works
0.10.1) andlatest