Fix weak-link deduplication in gap_analysis: check correct dict level#879
Open
PRAteek-singHWY wants to merge 1 commit intoOWASP:mainfrom
Open
Fix weak-link deduplication in gap_analysis: check correct dict level#879PRAteek-singHWY wants to merge 1 commit intoOWASP:mainfrom
PRAteek-singHWY wants to merge 1 commit intoOWASP:mainfrom
Conversation
PRAteek-singHWY
force-pushed
the
fix/gap-analysis-weak-link-dedup
branch
from
783b301 to
d326992
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #878
One-line fix for a deduplication bug in
application/database/db.py→gap_analysis().The Bug
Line 2224 checks
end_key in extra_paths_dict[key]butextra_paths_dict[key]is{"paths": {}}. The node IDend_keycan never match the only key"paths", so the condition is alwaysFalse. This breaks weak-path deduplication and inflates theextracount shown to users.The strong-path branch at line 2211 already does this correctly:
end_key in extra_paths_dict[key]["paths"].