feat(logging): add logging to DCE and common modules - #164
Draft
MohamedNasser8 wants to merge 3 commits into
Draft
feat(logging): add logging to DCE and common modules#164MohamedNasser8 wants to merge 3 commits into
MohamedNasser8 wants to merge 3 commits into
Conversation
Several code paths swallowed failures with no indication:
ltorres6
marked this pull request as draft
July 23, 2026 15:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
While reading the DCE code I noticed two things:
fit_model()defaults toLevenberg-Marquardt when no fitter is passed, but nothing says so.
return a fallback, so a crashed run looks the same as a correct one.