r.reclass.area: add upper and lower option and rewrite with Tools API#7337
Open
ninsbl wants to merge 12 commits intoOSGeo:mainfrom
Open
r.reclass.area: add upper and lower option and rewrite with Tools API#7337ninsbl wants to merge 12 commits intoOSGeo:mainfrom
ninsbl wants to merge 12 commits intoOSGeo:mainfrom
Conversation
github-actions
Bot
added
raster
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Member
Author
|
Sorry for the noise. I actually ment to open the PR against my fork while working on it... |
…to reclass_area_improvement
Member
Author
|
Please note: I had to adjust the unit test testrra.py when testing the rmarea method with lesser mode. Before this PR r.reclass.area actualy could not apply the lesser mode with rmarea and silently applied the greater mode instead. Therefore also the identical expected results in the original version of testrra.py for modes lesser and greater_ with rmarea. I would consider that a bug actually, which is why I felt it was appropriate to change the expected output values for the test as done in this commit: 059c1ac With this PR the combination of modes lesser and greater_ with rmarea are possible and applied correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rewrites r.reclass.area with the Tools API and extends / changes the API in a backward compatible way.
The changes allow r.reclass.area to filter different ranges (upper/lower) in one go and allows users to benefit from new options
in the underlying tools (like minsize in r.clump). Also users can now safe some procesingtime depending on their workflows by being able to use different input and output.
Tests are extended accordingly and also backwards-compatibility is tested.