Repository navigation
incorporate brine+energy simulator in flow - #6368
Merged
Merged
Conversation
Contributor
Author
|
jenkins build this please |
akva2
added
the
manual:new-feature
totto82
self-requested a review
September 19, 2025 06:41
totto82
requested changes
Sep 19, 2025
totto82
left a comment
totto82
left a comment
Member
There was a problem hiding this comment.
The code changes are fine. But please add a small test for regression testing.
Contributor
Author
|
jenkins build this please |
Member
|
The only thing left to do now is to add the test case to the regression list. It should be sufficient to add to the list in set(_spe1_brine_tests
SPE1CASE1_BRINE
SPE1CASE2_BRINE_GASWATER
SPE1CASE1_BRINE_THERMAL
) |
Contributor
Author
|
Thanks for pointing this out. The test case is added. |
totto82
approved these changes
Mar 16, 2026
totto82
left a comment
totto82
left a comment
Member
There was a problem hiding this comment.
Thanks. I will merge it after I have added the reference data
jenkins4opm
pushed a commit
to jenkins4opm/opm-tests
that referenced
this pull request
Mar 16, 2026
PR OPM/opm-simulators#6368 Reason: PR OPM/opm-common#4656 PR OPM/opm-simulators#6368 opm-common = c9670f3bb58aa557cbb7429f0e779cae62600495 opm-grid = 29485c1370945fe39db3862ee4917a3bb3784449 opm-simulators = 3c3ca8f4d30804eb054b201ee00f226670539676 ### Changed Tests ### * spe1case1_brine_thermal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow running brine + energy simulations with
flow. This functionality relies on OPM/opm-common#4656