Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cmake with autotest
Change how the libdap4 cmake build runs the integration tests (aka. the autotool/autotest tests).
The first try at adding a cmake build for ported the tests used a bunch or Python code. It was complicated and really hard to use when a test failed. I have changed to a hybrid approach where cmake is used for the build and sets up ctest to run the unit tests. However, the new approach uses autoconf to set up the autotest tests and builds the tests using the original *.at files. Ctest is then used to run those. But since the shell scripts can be run themselves, it should be easier to use the tests when the code is broken. For example, we can use the --baselines=yes option to the scripts to build baselines for tests.
This change also removes ~1,000 lines of code.