feat: add delete button to question and news forms by GMetaxakis · Pull Request #4643 · ONEARMY/community-platform

GMetaxakis · 2026-03-01T15:10:18Z

PR Checklist

- Unit and/or e2e tests for the changes that have been added (for bug fixes / features)

PR Type

Feature

What is the new behavior?

Add DELETE API endpoints to api.questions.$id and api.news.$id with creator/admin authorization (soft-delete via deleted: true)
Add delete button with confirmation modal to QuestionForm and NewsForm (visible only in edit mode), matching the existing ResearchUpdateForm pattern
Add client-side deleteQuestion and deleteNews service functions
Add Cypress e2e tests for deleting questions and news

Does this PR introduce a DB Schema Change or Migration?

No

Git Issues

Closes #4265

Add soft-delete API endpoints (DELETE method) to api.questions.$id and api.news.$id with creator/admin authorization. Add client-side delete functions, delete buttons with confirmation modals in the edit forms, and Cypress tests for both content types. Closes ONEARMY#4265

cypress · 2026-03-01T15:23:17Z

onearmy-community-platform Run #9133

Run Properties: Failed #9133 • 910b9d4955: Merge branch 'feat/delete-questions-news' of https://github.com/GMetaxakis/commu...

Project	`onearmy-community-platform`
Branch Review	`pull/4643`
Run status	`Failed #9133`
Run duration	`30m 26s`
Commit	`910b9d4955: Merge branch 'feat/delete-questions-news' of https://github.com/GMetaxakis/commu...`
Committer	`Georgios Metaxakis`
View all properties for this run ↗︎

Test results
Failures	`1`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`96`
View all changes introduced in this branch ↗︎

Tests for review

src/integration/news/write.spec.ts • 1 failed test • ci-chrome

View Output Video

Test		Artifacts
[News.Write] > [Delete a news item] > [By Author]		`Test Replay` `Screenshots` `Video`

GMetaxakis · 2026-03-01T16:08:28Z

The E2E test failures are caused by the new published_at column not existing on the CI test Supabase instance.

The migration (20260301100000_add_news_published_at.sql) needs to be applied to the test database for the news API queries to work:

ALTER TABLE news ADD COLUMN published_at timestamptz;
UPDATE news SET published_at = created_at WHERE (is_draft = false OR is_draft IS NULL);

Once the migration is applied, the 4 failing news tests should pass.

benfurber · 2026-03-05T15:20:16Z

Hey @GMetaxakis, thanks for working on so many items atm. I'm confused by the branch name and some some of the changes in this branch. Are they all related to the creation date change?

GMetaxakis · 2026-03-05T16:28:46Z

Hey @benfurber, you're right — sorry about the confusion! I accidentally pushed the publish date changes onto this branch instead of keeping them on their own. I've now cleaned this up:

This PR is back to being purely the delete feature for questions and news (closing [feature] Delete button for all forms #4265) — title and description updated to match
The publish date fix has been moved to its own PR: fix: show publish date instead of draft creation date for news #4654 (closing [bug] Show Publish date not draft date #4479)

Should be much clearer now. Let me know if you have any questions!

src/pages/News/Content/Common/NewsForm.tsx

mariojsnunes · 2026-03-17T12:46:23Z

@GMetaxakis seems like both cypress tests for deleting news and questions are failing

…ns-news

The delete tests for questions and news used [data-cy=confirm] but the ConfirmModal component uses data-cy="Confirm.modal: Confirm".

mariojsnunes · 2026-03-23T16:23:16Z

Fixed the conflicts on this branch

mariojsnunes · 2026-03-23T16:44:29Z

@dalibormrska need your input here.
we have 2 ways of deleting an item currently.

For research appears on the item itself.

With this PR questions and library will have it on the form (need to edit first):

Technically it's simpler to not have it on the form, but we can do it however is best for UX.

dalibormrska · 2026-03-23T20:43:00Z

Judging now the logic decision and not necessarily the current layout, I lean towards the option of having just the edit button and the delete inside of the form.

mariojsnunes

just a minor thing about error handling.

we are now sending the error messages correctly from the api. so we should handle them correctly on the frontend as well.

Also please ensure my conflict resolution didn't break something :)

mariojsnunes · 2026-03-24T03:51:11Z

src/services/newsService.ts

+  });
+
+  if (response.status !== 200 && response.status !== 201) {
+    throw new Error('Error deleting news', { cause: 500 });


Should handle the error with the message sent from the api, see above.

mariojsnunes · 2026-03-24T03:51:48Z

src/services/questionService.ts

+  });
+
+  if (response.status !== 200 && response.status !== 201) {
+    throw new Error('Error deleting question', { cause: 500 });


(same as on newsService)
Should handle the error with the message sent from the api, see above.

mariojsnunes · 2026-03-24T03:52:41Z

src/pages/News/Content/Common/NewsForm.tsx

+      return;
+    }
+    setShowDeleteModal(false);
+    await newsService.deleteNews(id);


should handle the error here, maybe show an <Alert /> component

mariojsnunes · 2026-03-24T03:52:48Z

src/pages/Question/Content/Common/QuestionForm.tsx

+      return;
+    }
+    setShowDeleteModal(false);
+    await questionService.deleteQuestion(id);


should handle the error here, maybe show an <Alert /> component

- Read error messages from API response in newsService and questionService delete functions instead of using generic messages - Catch delete errors in NewsForm and QuestionForm and display them via the existing saveErrorMessage/FormWrapper error UI

mariojsnunes · 2026-03-30T08:15:23Z

@GMetaxakis the news delete test is failing

The news listing query was missing the deleted filter, causing soft-deleted news items to still appear in the /news page.

…xakis/community-platform into feat/delete-questions-news

GMetaxakis requested a review from a team as a code owner March 1, 2026 15:10

github-project-automation bot added this to Core Team - BAU list and Community Platform Mar 1, 2026

GMetaxakis force-pushed the feat/delete-questions-news branch from 3748fb6 to 41ba2ec Compare March 1, 2026 15:11

GMetaxakis changed the title ~~feat: add delete button to question and news forms~~ fix: show publish date instead of draft creation date for news Mar 1, 2026

GMetaxakis mentioned this pull request Mar 1, 2026

fix: show publish date instead of draft creation date for news #4645

Closed

3 tasks

GMetaxakis force-pushed the feat/delete-questions-news branch from d5ea96a to 41ba2ec Compare March 5, 2026 16:26

GMetaxakis changed the title ~~fix: show publish date instead of draft creation date for news~~ feat: add delete button to question and news forms Mar 5, 2026

ci: retrigger after branch cleanup

59b9d8a

mariojsnunes reviewed Mar 6, 2026

View reviewed changes

src/pages/News/Content/Common/NewsForm.tsx Outdated Show resolved Hide resolved

mariojsnunes added 2 commits March 8, 2026 12:45

Merge branch 'master' into feat/delete-questions-news

f98b62f

Merge branch 'master' into feat/delete-questions-news

4f1b5f3

GMetaxakis added 2 commits March 17, 2026 22:06

Merge remote-tracking branch 'origin/master' into feat/delete-questio…

cd5c981

…ns-news

fix: use correct data-cy selector for ConfirmModal in delete E2E tests

342860f

The delete tests for questions and news used [data-cy=confirm] but the ConfirmModal component uses data-cy="Confirm.modal: Confirm".

mariojsnunes added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Mar 18, 2026

mariojsnunes temporarily deployed to preview March 18, 2026 04:29 — with GitHub Actions Inactive

Merge branch 'master' into feat/delete-questions-news

84dceb7

mariojsnunes had a problem deploying to preview March 23, 2026 16:20 — with GitHub Actions Failure

mariojsnunes added Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview and removed Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview labels Mar 23, 2026

mariojsnunes temporarily deployed to preview March 23, 2026 16:22 — with GitHub Actions Inactive

mariojsnunes requested changes Mar 24, 2026

View reviewed changes

GMetaxakis deployed to preview March 24, 2026 10:16 — with GitHub Actions View deployment

Merge branch 'master' into feat/delete-questions-news

4668ad8

mariojsnunes had a problem deploying to preview March 25, 2026 08:09 — with GitHub Actions Failure

benfurber moved this to In progress in Core Team - BAU list Mar 28, 2026

Merge branch 'master' into feat/delete-questions-news

b5c2a90

mariojsnunes had a problem deploying to preview March 30, 2026 07:42 — with GitHub Actions Failure

fix

3717835

mariojsnunes had a problem deploying to preview March 30, 2026 07:55 — with GitHub Actions Failure

GMetaxakis added 2 commits March 31, 2026 11:01

fix: filter deleted news from listing endpoint

3b97a64

The news listing query was missing the deleted filter, causing soft-deleted news items to still appear in the /news page.

Merge branch 'feat/delete-questions-news' of https://github.com/GMeta…

910b9d4

…xakis/community-platform into feat/delete-questions-news

GMetaxakis had a problem deploying to preview March 31, 2026 08:01 — with GitHub Actions Failure

Uh oh!

Conversation

GMetaxakis commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Type

What is the new behavior?

Does this PR introduce a DB Schema Change or Migration?

Git Issues

Uh oh!

cypress bot commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

onearmy-community-platform Run #9133

Tests for review

Uh oh!

GMetaxakis commented Mar 1, 2026

Uh oh!

benfurber commented Mar 5, 2026

Uh oh!

GMetaxakis commented Mar 5, 2026

Uh oh!

Uh oh!

mariojsnunes commented Mar 17, 2026

Uh oh!

mariojsnunes commented Mar 23, 2026

Uh oh!

mariojsnunes commented Mar 23, 2026

Uh oh!

dalibormrska commented Mar 23, 2026

Uh oh!

mariojsnunes left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mariojsnunes Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

mariojsnunes Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

mariojsnunes Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

mariojsnunes Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

mariojsnunes commented Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

GMetaxakis commented Mar 1, 2026 •

edited

Loading

cypress bot commented Mar 1, 2026 •

edited

Loading

mariojsnunes left a comment •

edited

Loading