Skip to content

[14.0][IMP] shopfloor: Single pack transfer owner #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mt-software-de wants to merge 1 commit into
base: 14.0
Choose a base branch
from
Open

[14.0][IMP] shopfloor: Single pack transfer owner #1135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions shopfloor/services/single_pack_transfer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,14 +180,25 @@ def start(self, barcode, confirmation=None):

return self._response_for_scan_location(package_level)

def _prepare_picking_vals_for_package(self, package):
vals = {}
if package.owner_id:
vals["owner_id"] = package.owner_id.id
Comment on lines +185 to +186
Copy link
Copy Markdown
Contributor

@jbaudoux jbaudoux Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should do that only when you want to change ownership from what I remember.

The package will have an owner when all quants inside it have that owner.
The picking should keep the quant ownership during the transfer (unless you force another one on the picking). The created moves will have the owner of the quant inside the package. Same for the move lines.

Copy link
Copy Markdown
Author

@mt-software-de mt-software-de Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes in the normal case it is keeping the owner, but somehow in this scenario its not the case. I need to investigate why.

return vals

def _create_picking_for_package(self, package):
picking_vals = self._prepare_picking_vals_for_package(package)
StockPicking = self.env["stock.picking"].with_context(
default_picking_type_id=self.picking_types.id
)
picking = StockPicking.create(picking_vals)
return picking

def _create_package_level(self, package):
# this method can be called only if we have one picking type
# (allow_move_create==True on menu)
assert self.picking_types.ensure_one()
StockPicking = self.env["stock.picking"].with_context(
default_picking_type_id=self.picking_types.id
)
picking = StockPicking.create({})
picking = self._create_picking_for_package(package)
package_level = self.env["stock.package_level"].create(
{
"picking_id": picking.id,
Expand Down