[16.0][FIX] shopfloor_reception: Incorrect move line selection after partial receipt (without pack)#1125
Open
nicolas-delbovier-acsone wants to merge 4 commits intoOCA:16.0from
Conversation
Contributor
|
Hi @JuMiSanAr, @mmequignon, |
Author
nicolas-delbovier-acsone
changed the title
Author
|
We should use the field |
jbaudoux
reviewed
Jan 28, 2026
nicolas-delbovier-acsone
force-pushed
the
16.0-fix-shopfloor_reception-without-pack-wrong-line-selected
branch
2 times, most recently
from
42f7e21 to
9a2d592
Compare
jbaudoux
reviewed
Jan 28, 2026
When users don't use packages for receptions, we should not rely only on its presence on lines to not select them. So, rely also on line progress completed at 100% (after split) to select another one with same criteria
… line has been fully processed.
Add a test case to verify that when multiple users are working on the same lot, one user cannot take the move line from another when scanning a lot.
nicolas-delbovier-acsone
force-pushed
the
16.0-fix-shopfloor_reception-without-pack-wrong-line-selected
branch
from
9a2d592 to
85b8ba5
Compare
jbaudoux
reviewed
Jan 30, 2026
…or "no user". A condition on the lines filtered lines has been added so to ensure that 2 users working on the same move do not steal move lines from one another.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When performing a partial reception without packages, the system splits the stock.move.line into a completed line and a backorder line. Currently, the line selection logic incorrectly assumes that fully processed lines are the ones linked to a package. This causes the system to re-select the already-processed line (e.g., 3/3) instead of the remaining one (e.g., 0/7), blocking the completion of the transfer and causing data inconsistency.
Solution
Updated the move line selection logic to ensure that lines are selected based on the fact they have been completely processed or not.
This PR isolates and improves some change made in #1092 as to ease review (see this commit)