[19.0][MIG] website_google_tag_manager: Migration to 19.0#1131
Open
[19.0][MIG] website_google_tag_manager: Migration to 19.0#1131
Conversation
* [ADD] New module 'website_google_tag_manager' * [FIX] website_google_tag_manager - Added OCA as author * [FIX] website_google_tag_manager - Fix RST syntax error (duplicate implicit target name 'google tag manager') * [IMP] website_google_tag_manager - Replace 'openerp' tags by 'odoo' ones + Remove 'data' tags
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (8 of 8 strings) Translation: website-12.0/website-12.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_google_tag_manager/fr/
Currently translated at 100.0% (8 of 8 strings) Translation: website-12.0/website-12.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_google_tag_manager/pt_BR/
Currently translated at 100.0% (8 of 8 strings) Translation: website-14.0/website-14.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-14-0/website-14-0-website_google_tag_manager/es_AR/
Currently translated at 72.7% (8 of 11 strings) Translation: website-14.0/website-14.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-14-0/website-14-0-website_google_tag_manager/fr_FR/
Currently translated at 12.5% (1 of 8 strings) Translation: website-16.0/website-16.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_google_tag_manager/it/
Currently translated at 100.0% (8 of 8 strings) Translation: website-16.0/website-16.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_google_tag_manager/es/
Currently translated at 100.0% (8 of 8 strings) Translation: website-16.0/website-16.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-16-0/website-16-0-website_google_tag_manager/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: website-17.0/website-17.0-website_google_tag_manager Translate-URL: https://translation.odoo-community.org/projects/website-17-0/website-17-0-website_google_tag_manager/
…anager Adding script before the wrapwrap element affects style [1] and hide the nav bar behind of the main menu, so it is required adding it after the wrapwrap element, the same way as [2] does it. Reference: - [1] https://github.com/odoo/odoo/blob/32a07bf4/addons/website/static/src/scss/website.scss#L200 - [2] https://github.com/odoo/odoo/blob/32a07bf4/addons/website/views/website_templates.xml#L151
There was a problem hiding this comment.
Pull Request Overview
This pull request migrates the website_google_tag_manager module from Odoo 18.0 to 19.0. The migration involves updating the manifest version, adjusting template inheritance, and maintaining compatibility with the new Odoo version while preserving all existing functionality for Google Tag Manager integration.
- Updated module version from 18.0.1.0.0 to 19.0.1.0.0 in the manifest
- Modified template positioning to use a more robust XPath selector for the body element
- Maintained all existing Google Tag Manager functionality and configuration options
Reviewed Changes
Copilot reviewed 71 out of 73 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| website_google_tag_manager/manifest.py | Updated version to 19.0.1.0.0 for Odoo 19.0 compatibility |
| website_google_tag_manager/views/website_templates.xml | Modified XPath selector for template inheritance positioning |
| All other files | New files added as part of the complete module structure for 19.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
atchuthan
approved these changes
Nov 4, 2025
atangaraj
approved these changes
Nov 4, 2025
Contributor
|
This PR has the |
Member
|
@OCA/website-maintainers This PR is ready for merge. |
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.