[BP][IMP] website_cookiefirst: Replace deprecated Cookiefirst functionality

[NICO-SOLUTIONS]

• replace banner.js with new consent.js script using domain and identifier
• back ported from V17 PR ([IMP] website_cookiefirst: Replace deprecated Cookiefirst functionality #1110)

[ioans73]

LGTM

[mariancuadranetkia]

LGTM!

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[mariancuadranetkia]

@pedrobaeza
can we merge this one? or is there something that needs to be adjusted here as well?
thanks

[pedrobaeza]

/ocabot merge major

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-1115-by-pedrobaeza-bump-major, awaiting test results.

[OCA-git-bot]

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-1115-by-pedrobaeza-bump-major.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[pedrobaeza]

Please rebase and check the failing CI.

[mariancuadranetkia]

@NICO-SOLUTIONS can you rebase and check pls? Thx!

[NICO-SOLUTIONS]

@pedrobaeza
@mariancuadranetkia

Hey,
From my understanding, observing the logs, there is nothing to rebase here. The CI failures appear to be unrelated to this PR and originate from upstream issues in the following modules:

website_conditional_visibility_user_group (test_snippet_for_internal_users)
website_snippet_country_dropdown (test_01_demo_country_dropdown_tour)

I verified that both tests also fail on the target branch (15.0), so this seems to be an existing issue that should be addressed independently of this PR.

I thought it might be helpful to clarify, so the review can focus on the relevant changes. If I missed anything, please let me know.

[pedrobaeza]

Well, in any case, while not fixing that problems, anything can't be merged in this branch.

[NICO-SOLUTIONS]

Well, in any case, while not fixing that problems, anything can't be merged in this branch.

@pedrobaeza
I understand... I can take a closer look at the failing tests when I get a chance, but I can’t investigate further right now.

Just wanted to share what I saw in the logs for now.

[pedrobaeza]

Yes, thanks, and I don't want to charge you. Just also saying that we can't merge things in the branch while in red. It's a "community game".

[NICO-SOLUTIONS]

Yes, thanks, and I don't want to charge you. Just also saying that we can't merge things in the branch while in red. It's a "community game".

@pedrobaeza
no worries at all – I didn’t feel you were putting anything on me. I really appreciate your input, thanks for that!

[mariancuadranetkia]

@pedrobaeza @NICO-SOLUTIONS
I'm not sure if I'd know how to help to fix these problems, but... if I try, how I should do it?
Create a PR to try to fix detected problems? Different PRs for different modules?
Thanks!

[pedrobaeza]

Yes, you can put an extra PR fixing the problems. It should be one PR, as we can't merge if not everything green, but with one commit per module.

[NICO-SOLUTIONS]

@pedrobaeza @NICO-SOLUTIONS I'm not sure if I'd know how to help to fix these problems, but... if I try, how I should do it? Create a PR to try to fix detected problems? Different PRs for different modules? Thanks!

@mariancuadranetkia
the source of the problem is...
website_conditional_visibility_user_group (test_snippet_for_internal_users)
website_snippet_country_dropdown (test_01_demo_country_dropdown_tour)

these tests needed to be checked and corrected in order to get a green run. You can check the logs of the failing run...

1. https://github.com/OCA/website/actions/runs/17119432670/job/48556825722
2. https://github.com/OCA/website/actions/runs/17119432670/job/48556825718

[mariancuadranetkia]

@NICO-SOLUTIONS @pedrobaeza
Thanks for your help
I'm sorry but I have more doubts now,.. I created fork and if I pass tests in local I dont have errors...
So I've checked errors and I see:

2025-08-21 06:57:55,963 348 ERROR odoo odoo.addons.website_conditional_visibility_user_group.tests.test_conditional_visibility_user_group: FAIL: TestConditionalVisibilityUserGroup.test_snippet_for_internal_users
Traceback (most recent call last):
  File "/__w/website/website/website_conditional_visibility_user_group/tests/test_conditional_visibility_user_group.py", line 17, in test_snippet_for_internal_users
    self.start_tour("/", "conditional_visibility_only_internal_user", login="admin")
  File "/opt/odoo/odoo/tests/common.py", line 1778, in start_tour
    return self.browser_js(url_path=url_path, code=code, ready=ready, **kwargs)
  File "/opt/odoo/odoo/tests/common.py", line 1742, in browser_js
    self.assertTrue(self.browser._wait_ready(ready), 'The ready "%s" code was always falsy' % ready)
AssertionError: False is not true : The ready "odoo.__DEBUG__.services['web_tour.tour'].tours['conditional_visibility_only_internal_user'].ready" code was always falsy

Some lines before I can see timeout...

2025-08-21 06:57:55,946 348 INFO odoo odoo.addons.website_conditional_visibility_user_group.tests.test_conditional_visibility_user_group.TestConditionalVisibilityUserGroup: timeout exceeded while waiting for id : 177022 
2025-08-21 06:57:55,946 348 WARNING odoo odoo.addons.website_conditional_visibility_user_group.tests.test_conditional_visibility_user_group.TestConditionalVisibilityUserGroup: Couldn't capture screenshot: expected image data, got {} 

So, I'm not sure how continue with this...

[pedrobaeza]

Other module installed at the same time in the repo is provoking the problem.

[NICO-SOLUTIONS]

@pedrobaeza
@mariancuadranetkia

Several tests are failing with the error message: "The ready odoo.DEBUG.services['web_tour.tour'].tours['...'].ready code was always falsy."

This occurs across multiple modules, including website_snippet_country_dropdown, website_snippet_marginless_gallery, and website_conditional_visibility_user_group.
Essentially, the browser never sees the tour's ready flag as true, which causes start_tour to fail consistently.

[mariancuadranetkia]

Hi
@pedrobaeza @NICO-SOLUTIONS
In a new database, all is right, without errors. But, if I exec again tests with same database, so, I can see errors...
I'm sorry but I can't continue checking this until 01/09... This day I'll check if there are news or if I have more 'ideas' to continue and check these problems.

Thank you very much!!!

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[NICO-SOLUTIONS]

@OCA/website-maintainers
could you please remove the stale tag?