[MIG] website_local_font: Migration to 16.0#1051
[MIG] website_local_font: Migration to 16.0#1051Reyes4711-S73 wants to merge 3 commits intoOCA:16.0from
Conversation
b097857 to
4a24839
Compare
|
/ocabot migration website_local_font |
4a24839 to
84f2984
Compare
|
@xaviedoanhduy Done |
xaviedoanhduy
left a comment
There was a problem hiding this comment.
LGTM, thanks for the above changes
|
Thanks for this @Reyes4711-S73 , do you mind rebasing so we can test it on runboat? |
f01dfab to
a9b0f21
Compare
christian-ramos-tecnativa
left a comment
There was a problem hiding this comment.
Code and functional review OK.
Please add the versión to the PR title [16.0][MIG] website_local_font: Migration to 16.0
Thanks for the fast response 😄
|
This PR has the |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
a9b0f21 to
81c70e9
Compare
|
@OCA/website-maintainers could anyone merge this PR? |
|
@Reyes4711-S73 Can you rebase your branch with latest commits from https://github.com/OCA/website please |
[ADD] website_local_fonts: add new module [ADD] website_local_fonts: add new module Updated Test Folder Name Changes as per suggestions in the PR Added missing setup file
81c70e9 to
5c2d6e2
Compare
|
@tarteo Done |
|
This PR has the |
tarteo
left a comment
There was a problem hiding this comment.
Tested on runboat
I tried otf and ttf files, but only ttf worked.
Seems that I can only have one local font at a time and I cannot remove it which the screenshots (website_local_font/static/description/NewlyAddedFont.png) suggests it was possible in previous versions.
(non-blocking issue) the font won't be applied in the editor after saving. I need to refresh it
after save:

after refresh:

It says it's served by google (the blue cloud icon) which is not the case for local fonts.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
@tarteo I reviewed it and I could upload an oft file and it works when you save the changes. |
5c2d6e2 to
770001a
Compare
|
@Reyes4711-S73 Did you look at the issue why I can't remove existing uploaded fonts? And why I can only have one local font at the time? This seems to be possible in previous versions, 15.0:
16.0:
|
85a4db2 to
6a96f38
Compare
|
@tarteo Fixed delete button |
6a96f38 to
1b6dc7c
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
1b6dc7c to
e8162d0
Compare



Standard migration to 16.0
Reopen from #1028