Skip to content

[19.0][MIG] hr_timesheet_day_week: Migration to 19.0#859

Merged
OCA-git-bot merged 3 commits intoOCA:19.0from
BizzAppDev-Systems:19.0-mig-hr_timesheet_day_week-BAD
Apr 24, 2026
Merged

[19.0][MIG] hr_timesheet_day_week: Migration to 19.0#859
OCA-git-bot merged 3 commits intoOCA:19.0from
BizzAppDev-Systems:19.0-mig-hr_timesheet_day_week-BAD

Conversation

@bizzappdev
Copy link
Copy Markdown
Contributor

@bizzappdev bizzappdev commented Jan 12, 2026

No description provided.

dalonsod and others added 3 commits November 24, 2025 18:42
@dalonsod @bizzappdev
[ADD] hr_timesheet_day_week
ea352ee 
For timesheets, enables search, group by the day of the week.
This is useful when e.g. weekend timesheets needs to be located.
@mymage @bizzappdev
Added translation using Weblate (Italian)
ca0726f
@bizzappdev
[MIG] hr_timesheet_day_week: Migration to 19.0
25d3186
alexey-pelykh
alexey-pelykh approved these changes Feb 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@alexey-pelykh alexey-pelykh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Clean 19.0 migration. The pre_init_hook for populating the day_week column is a nice touch — avoids recompute on large datasets during install. Code review LGTM.

@dalonsod
Copy link
Copy Markdown
Contributor

dalonsod commented Mar 5, 2026

Hello @bizzappdev this port looks good, would you resume this PR and move to ready state?

@MohamedOsman7
Copy link
Copy Markdown
Contributor

MohamedOsman7 commented Apr 1, 2026

@bizzappdev Would you mark this PR as ready for review?

CRogos
CRogos approved these changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Apr 20, 2026

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@bizzappdev bizzappdev marked this pull request as ready for review April 23, 2026 15:04
@bizzappdev
Copy link
Copy Markdown
Contributor Author

bizzappdev commented Apr 23, 2026

Module is ready for final review

dalonsod
dalonsod approved these changes Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally tested 👍

@Saran440
Copy link
Copy Markdown
Member

Saran440 commented Apr 24, 2026

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Apr 24, 2026

This PR looks fantastic, let's merge it!
Prepared branch 19.0-ocabot-merge-pr-859-by-Saran440-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4333229 into OCA:19.0 Apr 24, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Apr 24, 2026

Congratulations, your PR was merged at 10ad7f5. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-pelykh alexey-pelykh alexey-pelykh approved these changes

+2 more reviewers

@CRogos CRogos CRogos approved these changes

@dalonsod dalonsod dalonsod approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@bizzappdev @dalonsod @MohamedOsman7 @OCA-git-bot @Saran440 @alexey-pelykh @CRogos @mymage