[19.0][MIG] hr_employee_cost_history: Migration to 19.0#835
[19.0][MIG] hr_employee_cost_history: Migration to 19.0#835bizzappdev wants to merge 9 commits intoOCA:19.0from
Conversation
…roactively in timesheets This module allows to modify retroactively timesheet costs from a given date and store those changes in a new model. @moduon MT-4266
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
alexey-pelykh
left a comment
alexey-pelykh
left a comment
There was a problem hiding this comment.
Thanks for the migration! Code looks good overall, one thing:
freezegun is listed in external_dependencies but it's only used in tests. This means it becomes a runtime install requirement for all users, even though they'll never need it outside of the test suite. It should be removed from the manifest — test deps don't belong in external_dependencies.
| "author": "Moduon, Odoo Community Association (OCA)", | ||
| "maintainers": ["SabrinaRMArtin", "rafaelbn"], | ||
| "license": "LGPL-3", | ||
| "external_dependencies": {"python": ["freezegun"]}, |
There was a problem hiding this comment.
freezegun is a test-only dependency (only imported in tests). It shouldn't be listed in external_dependencies — that's for runtime requirements. Users shouldn't need to install it.
github-actions
bot
removed
the
stale
5 participants
No description provided.