[18.0][FIX] base_search_custom_field_filter: Error when define filters with related fields#1232
Conversation
|
Hi @pedrobaeza, |
CarlosRoca13
force-pushed
the
18.0-FIX-base_search_custom_field_filter
branch
2 times, most recently
from
b41ef8b to
a5d1864
Compare
mariancuadranetkia
left a comment
mariancuadranetkia
left a comment
There was a problem hiding this comment.
I've tested in runboat and now it's working.
|
@carlosdauden can you check this? |
There was a problem hiding this comment.
Functional review 👍🏻
I added this commit in my migration to v19: #1238
|
@pedrobaeza |
… related fields Steps to reproduce the behavior: 1. Define a custom filter with . notation like partner_id.lang 2. Access to the model defined, to check if we can use this filter. An error was thrown With this changes the field is defined in the correct point and the error is not thrown.
CarlosRoca13
force-pushed
the
18.0-FIX-base_search_custom_field_filter
branch
from
a5d1864 to
4f6e018
Compare
|
Let's see if doing a rebase the problem is solved |
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
This PR has the |
|
Congratulations, your PR was merged at 958f321. Thanks a lot for contributing to OCA. ❤️ |
5 participants
Steps to reproduce the behavior:
An error was thrown
With this changes the field is defined in the correct point and the error is not thrown.
ping @pedrobaeza @carlos-lopez-tecnativa @mariancuadranetkia
cc @Tecnativa
This PR solves the Issue: #1231