Skip to content

[18.0][IMP] base_custom_filter: add configurable insertion point for filter groups#1220

Open
yostashiro wants to merge 1 commit intoOCA:18.0from
qrtl:18.0-imp-base_custom_filter
Open

[18.0][IMP] base_custom_filter: add configurable insertion point for filter groups#1220
yostashiro wants to merge 1 commit intoOCA:18.0from
qrtl:18.0-imp-base_custom_filter

Conversation

@yostashiro
Copy link
Member

  • Add insert_xpath, insert_position, and separator_position fields to control filter placement in search views
  • Fix custom filters appearing under Favorites
  • Fix custom filters not showing when //search/filter node didn't exist
  • Make ir.filters name field translatable

@qrtl QT6218

… groups

- Add insert_xpath, insert_position, and separator_position fields
  to control filter placement in search views
- Fix custom filters appearing under Favorites
- Fix custom filters not showing when //search/filter node didn't exist
- Make ir.filters name field translatable
@OCA-git-bot
Copy link
Contributor

Hi @ForgeFlow, @AshishHirapara,
some modules you are maintaining are being modified, check this out!

@yostashiro
Copy link
Member Author

The main improvement: we now have better control over where the custom filters should show.

image

Copy link
Contributor

@AungKoKoLin1997 AungKoKoLin1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review: it works as expected in runboat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants