[18.0][IMP] template_content_swapper: add feature to use domain for applying some specific records in report pdfs#1214
Open
AungKoKoLin1997 wants to merge 1 commit intoOCA:18.0from
Conversation
Contributor
|
Hi @yostashiro, |
yostashiro
suggested changes
Jan 10, 2026
Member
yostashiro
left a comment
yostashiro
left a comment
There was a problem hiding this comment.
Could we add tests, or create a test module?
template_content_swapper/views/template_content_mapping_views.xml
Outdated
Show resolved
Hide resolved
AungKoKoLin1997
force-pushed
the
18.0-imp_template_content_swapper_domain
branch
6 times, most recently
from
0d5cc3f to
441c897
Compare
nobuQuartile
reviewed
Mar 2, 2026
AungKoKoLin1997
force-pushed
the
18.0-imp_template_content_swapper_domain
branch
from
441c897 to
76aada0
Compare
AungKoKoLin1997
force-pushed
the
18.0-imp_template_content_swapper_domain
branch
from
76aada0 to
e0eb6c5
Compare
yostashiro
reviewed
Mar 2, 2026
AungKoKoLin1997
force-pushed
the
18.0-imp_template_content_swapper_domain
branch
2 times, most recently
from
9b4306c to
9f6d777
Compare
yostashiro
suggested changes
Mar 2, 2026
AungKoKoLin1997
force-pushed
the
18.0-imp_template_content_swapper_domain
branch
from
9f6d777 to
50c252e
Compare
…g some specific records in report pdfs Co-authored-by: Yoshi Tashiro <tashiro@quartile.co>
AungKoKoLin1997
force-pushed
the
18.0-imp_template_content_swapper_domain
branch
from
0aafe6e to
b06de95
Compare
yostashiro
approved these changes
Mar 3, 2026
Member
yostashiro
left a comment
yostashiro
left a comment
There was a problem hiding this comment.
Code review and functional test. LGTM. 👍
Would be good to add a form view to the template mapping as the list view is getting more cluttered.
Contributor
Author
@yostashiro Yes, I will follow up with separate PR since it is not related with current changes and to be better for discussing separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward port of #1202
This PR adds an improvement to restrict the applying changes only for some specific records by adding domain in configuration.
With this changes, we can only adjust the content of report pdf depends on some condition, not globally.
@qrtl QT5088