Skip to content

[19.0][FIX] upgrade_analysis: don't generate eval="''" attributes #3541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OCA-git-bot merged 1 commit into from
Mar 9, 2026
+5 −1
Merged

[19.0][FIX] upgrade_analysis: don't generate eval="''" attributes #3541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion upgrade_analysis/models/upgrade_analysis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,9 @@ def _get_xml_diff(
# (usually None)
model = self.env[local_record.attrib["model"]]
field = model._fields[attribs["name"]]
attribs["eval"] = ast.unparse(ast.Constant(field.falsy_value))
eval_constant = ast.unparse(ast.Constant(field.falsy_value))
if eval_constant != "''":
attribs["eval"] = eval_constant
element.append(etree.Element(record_remote_dict[key].tag, attribs))
else:
oldrepr = self._get_node_value(record_remote_dict[key])
Expand Down
2 changes: 2 additions & 0 deletions upgrade_analysis/tests/test_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ def test_xml_comparison(self):
name="module_ids"
eval="[Command.set([ref('base.module_web')])]"
/>
<field name="display_name">some name</field>
</record>
"""
),
Expand All @@ -150,3 +151,4 @@ def test_xml_comparison(self):
},
)
self.assertIn('<field name="module_ids" eval="None"/>', diff)
self.assertIn('<field name="display_name"/>', diff)