[MIG] module_analysis: Migration to 18.0 by absal-smile · Pull Request #3184 · OCA/server-tools

absal-smile · 2025-02-03T10:00:51Z

No description provided.

fixup! [ADD] new module module_analysis fixup! fixup! [ADD] new module module_analysis fixup! fixup! fixup! [ADD] new module module_analysis fixup! fixup! fixup! fixup! [ADD] new module module_analysis IMP exception message fixup! fixup! fixup! fixup! fixup! [ADD] new module module_analysis [REF] remove use of cloc. use pygount librairy instead fixup! [REF] remove use of cloc. use pygount librairy instead fixup! fixup! [REF] remove use of cloc. use pygount librairy instead Apply suggestions from code review Co-Authored-By: David Beal <david.beal@akretion.com> Update module_analysis/views/menu.xml Co-Authored-By: David Beal <david.beal@akretion.com> Update module_analysis/tests/test_module.py Co-Authored-By: David Beal <david.beal@akretion.com> Update module_analysis/readme/CONFIGURE.rst Co-Authored-By: David Beal <david.beal@akretion.com> [IMP] handle encoding [UPD] Update module_analysis.pot [UPD] README.rst [UPD] README.rst

Currently translated at 100.0% (35 of 35 strings) Translation: server-tools-12.0/server-tools-12.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-module_analysis/zh_CN/ [UPD] README.rst

Currently translated at 100.0% (35 of 35 strings) Translation: server-tools-13.0/server-tools-13.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-13-0/server-tools-13-0-module_analysis/it/

[MIG] module_analysis: Migration to 15.0

…cause the analysis is partial (it also make the update slower) ; Add instead a cron task that is executed nightly to update analysis automatically

Currently translated at 97.2% (35 of 36 strings) Translation: server-tools-15.0/server-tools-15.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-module_analysis/it/

Analyse can take some time and a cron task can do it every day if needed, no need to recompute it in real time

…e there is no post install hook anymore

… cron. Usefull if we want to analyse the code for uninstalled modules for instance

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_analysis/

Currently translated at 91.6% (33 of 36 strings) Translation: server-tools-16.0/server-tools-16.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_analysis/it/

Currently translated at 100.0% (36 of 36 strings) Translation: server-tools-16.0/server-tools-16.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_analysis/es/

Currently translated at 91.6% (33 of 36 strings) Translation: server-tools-16.0/server-tools-16.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_analysis/it/

Currently translated at 100.0% (36 of 36 strings) Translation: server-tools-16.0/server-tools-16.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_analysis/it/

…e to module's folder Fixes OCA#3042.

absal-smile · 2025-02-03T13:34:17Z

@OCA-git-bot

gdgellatly · 2025-04-15T06:24:19Z

@absal-smile I think this needs a rebase

adasatorres · 2025-10-08T14:47:34Z

module_analysis/models/ir_module_module.py

+        return {
+            ".py": {"code": "python_code_qty"},
+            ".xml": {"code": "xml_code_qty"},
+            ".js": {"code": "js_code_qty"},
+            ".css": {"code": "css_code_qty"},
+            ".scss": {"code": "scss_code_qty"},


Good morning, I recommend setting a specific version of pygount, since in the latest releases the code attribute no longer exists in the SourceAnalysis class. You can use the code_count property instead to obtain the same value.

I’m including a link to the code here:
https://github.com/roskakori/pygount/blob/2d424a00ee020555e74b1a7a5f9334f03ee5f247/pygount/analysis.py#L257

+1 on changing code to code_count

legalsylvain · 2025-11-25T20:13:22Z

Hi @absal-smile. Thanks for porting this module. could you :

rebase, to solve conflict.
cherry pick this commit https://github.com/OCA/server-tools/pull/3441/files to solve @adasatorres remarks ?

Thanks !

legalsylvain · 2025-11-25T20:15:17Z

module_analysis/tests/test_module.py

-                    " installed."
-                )
-                % (module.name),
+                    "module {} doesn't have code analysed defined, "


"module %(module_name)s doesn't have code analysed defined, "

is easier to translate in weblate tools.

legalsylvain · 2025-11-25T20:15:51Z

module_analysis/data/ir_cron.xml

        <field name="interval_type">days</field>
        <field name="nextcall" eval="(DateTime.today()).strftime('%Y-%m-%d')" />
-        <field name="numbercall">-1</field>
+        <!-- <field name="numbercall">-1</field> -->


Why did you commented this line ?

adasatorres · 2025-12-11T11:39:13Z

Hi @legalsylvain, do you think I could open a PR to continue with this migration, since it seems to have stalled? Or should we wait for the author of this PR to show some signs of activity?

legalsylvain · 2025-12-11T12:08:46Z

@adasatorres please continue !

adasatorres · 2025-12-11T13:08:44Z

@legalsylvain #3464

legalsylvain and others added 30 commits February 3, 2025 10:10

Added translation using Weblate (Chinese (Simplified))

5fa074d

[IMP] module_analysis: black, isort, prettier

5e05176

[MIG] module_analysis: Migration to 13.0

10b05c0

Fix pre-commit warnings

15dda63

fixup! Fix pre-commit warnings

a58e7ec

Skip _test modules from test_installed_modules

9956b56

Remove anonymous variable _

fcceb99

fixup! [MIG] module_analysis: Migration to 13.0

a1bf9ad

[Fix] author_txt_list assign

06ecacb

Fix _get_files_to_analyse

85afb8b

Added translation using Weblate (Italian)

619a336

Translated using Weblate (Italian)

dfe2a1f

Currently translated at 100.0% (35 of 35 strings) Translation: server-tools-13.0/server-tools-13.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-13-0/server-tools-13-0-module_analysis/it/

[FIX] module_analysis: correct syntax

dcfd60d

[MIG] module_analysis: Migration to 15.0

69782f4

[MIG] module_analysis: Migration to 15.0

[FIX+IMP] module_analysis : remove analysis when updating modules, be…

85be102

…cause the analysis is partial (it also make the update slower) ; Add instead a cron task that is executed nightly to update analysis automatically

[UPD] Update module_analysis.pot

904f18a

[UPD] README.rst

665b570

Translated using Weblate (Italian)

dbf5e10

Currently translated at 97.2% (35 of 36 strings) Translation: server-tools-15.0/server-tools-15.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-module_analysis/it/

[16.0][MIG] module_analysis : migrate to 16

79dc54d

[IMP] Remove automatic analyse at installation and update

5d78126

Analyse can take some time and a cron task can do it every day if needed, no need to recompute it in real time

[IMP] Add SCSS SLOC measure

7a4a2f6

[FIX] fix usage of cron data, deactivate it by default

e26cd08

[REF] module_analysis: add legalsylvain as maintainers

2c373b0

[FIX] test: proper analysis before testing

4f36e08

[FIX] Playing test after install must not be mandatory anymore becaus…

74bbad3

…e there is no post install hook anymore

module_analysis : Update readme

112829f

[IMP] module_analysis : allow to pass a custom domain to the analysis…

950f4b4

… cron. Usefull if we want to analyse the code for uninstalled modules for instance

[UPD] Update module_analysis.pot

ceb1392

oca-ci and others added 15 commits February 3, 2025 10:10

[UPD] Update module_analysis.pot

4272a4e

Update translation files

c202292

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_analysis/

Translated using Weblate (Italian)

f5e277c

Currently translated at 91.6% (33 of 36 strings) Translation: server-tools-16.0/server-tools-16.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_analysis/it/

Added translation using Weblate (Spanish)

ba270d8

Translated using Weblate (Spanish)

1c48aab

Currently translated at 100.0% (36 of 36 strings) Translation: server-tools-16.0/server-tools-16.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_analysis/es/

[UPD] README.rst

7a8030e

Translated using Weblate (Italian)

a987e64

Currently translated at 91.6% (33 of 36 strings) Translation: server-tools-16.0/server-tools-16.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_analysis/it/

Translated using Weblate (Italian)

1a1c69a

Currently translated at 91.6% (33 of 36 strings) Translation: server-tools-16.0/server-tools-16.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_analysis/it/

Translated using Weblate (Italian)

251cf71

Currently translated at 100.0% (36 of 36 strings) Translation: server-tools-16.0/server-tools-16.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_analysis/it/

Translated using Weblate (Italian)

1bbcd55

Currently translated at 100.0% (36 of 36 strings) Translation: server-tools-16.0/server-tools-16.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_analysis/it/

Translated using Weblate (Italian)

8aeadb5

Currently translated at 100.0% (36 of 36 strings) Translation: server-tools-16.0/server-tools-16.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_analysis/it/

[MIG] module_analysis: Migration to 17.0

6c11c02

[UPD] Update module_analysis.pot

8eae0f8

[17.0][FIX] module_analysis: interpret exclude_directories as relativ…

9cac561

…e to module's folder Fixes OCA#3042.

[IMP] module_analysis: pre-commit auto fixes

b52fc86

absal-smile mentioned this pull request Feb 3, 2025

Migration to version 18.0 #3047

Open

40 tasks

absal-smile force-pushed the 18.0-mig-module_analysis branch from b2619da to 37a0d6b Compare February 3, 2025 10:29

[MIG] module_analysis: Migration to 18.0

8c6705a

absal-smile force-pushed the 18.0-mig-module_analysis branch from 37a0d6b to 8c6705a Compare February 3, 2025 10:37

adasatorres suggested changes Oct 8, 2025

View reviewed changes

legalsylvain reviewed Nov 25, 2025

View reviewed changes

legalsylvain added this to the 18.0 milestone Nov 25, 2025

legalsylvain marked this pull request as draft November 25, 2025 20:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[MIG] module_analysis: Migration to 18.0#3184

[MIG] module_analysis: Migration to 18.0#3184
absal-smile wants to merge 51 commits intoOCA:18.0from
absal-smile:18.0-mig-module_analysis

absal-smile commented Feb 3, 2025

Uh oh!

absal-smile commented Feb 3, 2025

Uh oh!

gdgellatly commented Apr 15, 2025

Uh oh!

adasatorres Oct 8, 2025

Uh oh!

Honeyxilia Nov 7, 2025

Uh oh!

legalsylvain commented Nov 25, 2025

Uh oh!

legalsylvain Nov 25, 2025

Uh oh!

legalsylvain Nov 25, 2025

Uh oh!

adasatorres commented Dec 11, 2025

Uh oh!

legalsylvain commented Dec 11, 2025

Uh oh!

adasatorres commented Dec 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

Uh oh!

Conversation

absal-smile commented Feb 3, 2025

Uh oh!

absal-smile commented Feb 3, 2025

Uh oh!

gdgellatly commented Apr 15, 2025

Uh oh!

adasatorres Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Honeyxilia Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

legalsylvain commented Nov 25, 2025

Uh oh!

legalsylvain Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

legalsylvain Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

adasatorres commented Dec 11, 2025

Uh oh!

legalsylvain commented Dec 11, 2025

Uh oh!

adasatorres commented Dec 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants