[18.0][FIX] sale_global_discount: discount amounts with round_globally rounding method - #4557
Open
LorenzoC0 wants to merge 1 commit into
Open
[18.0][FIX] sale_global_discount: discount amounts with round_globally rounding method#4557LorenzoC0 wants to merge 1 commit into
LorenzoC0 wants to merge 1 commit into
Conversation
LorenzoC0
force-pushed
the
18.0-fix-sale_global_discount-rounding
branch
from
August 31, 2026 13:35
cc8a9a1 to
09a5c88
Compare
eLBati
reviewed
Sep 2, 2026
LorenzoC0
force-pushed
the
18.0-fix-sale_global_discount-rounding
branch
from
September 2, 2026 10:27
09a5c88 to
d989819
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch disables the calculation of global discount amounts if none is selected and computes discount amounts consistently from per-line subtotals instead of mixing them with globally rounded order totals.
You can trigger a -0,01€ discount without any global discount selected (or a global discount set to 0%) with these steps: